On Thu, Nov 19, 2020 at 09:26:20PM +0200, Andy Shevchenko wrote:
> It seems nobody tested the debug() option in spin_lock_irqsave().
> Currently, when #define DEBUG, it spoils the compiler with
>
> In file included from drivers/usb/dwc3/gadget.c:18:
> drivers/usb/dwc3/gadget.c: In function ‘dwc3_gadget_set_selfpowered’:
> include/log.h:235:4: warning: ‘flags’ is used uninitialized in this function
> [-Wuninitialized]
> 235 | printf(pr_fmt(fmt), ##args); \
> | ^~~~~~
> drivers/usb/dwc3/gadget.c:1347:17: note: ‘flags’ was declared here
> 1347 | unsigned long flags;
> | ^~~~~
>
> and so on...
> Drop useless debug() call to make compiler happy.
>
> Fixes: 0c06db598367 ("lib, linux: move linux specific defines to
> linux/compat.h")
> Cc: Heiko Schocher <h...@denx.de>
> Cc: Tom Rini <tr...@ti.com>
> Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com>
> Reviewed-by: Heiko Schocher <h...@denx.de>Applied to u-boot/master, thanks! -- Tom
signature.asc
Description: PGP signature
