On Monday, October 11, 2010 16:29:41 Scott Wood wrote: > On Sun, Oct 10, 2010 at 06:37:40AM -0400, Mike Frysinger wrote: > > --- a/common/cmd_nand.c > > +++ b/common/cmd_nand.c > > @@ -309,6 +309,8 @@ > > > > if (argc < 2) > > goto usage; > > > > + nand_init(); > > + > > Also do_nandboot().
does it need to be before the mtdparts init stuff, or can it be in
nand_load_image() ?
> > --- a/common/env_nand.c
> > +++ b/common/env_nand.c
> > @@ -359,6 +359,8 @@ void env_relocate_spec(void)
> > return;
> > }
> >
> > + nand_init();
> > +
> >
> > if (readenv(CONFIG_ENV_OFFSET, (u_char *) tmp_env1))
> > puts("No Valid Environment Area found\n");
> >
> > @@ -404,6 +406,8 @@ void env_relocate_spec(void)
> > free(tmp_env1);
> > free(tmp_env2);
> >
> > +#else
> > + nand_init();
> >
> > #endif /* ! ENV_IS_EMBEDDED */
>
> Do we really need to initialize NAND if the environment is embedded, or
> could it be delayed to when the environment is saved?
the reason i picked env_relocate_spec() is because i'd have to push the init
into the read/write/save code paths. and those may be executed multiple times
while running. the expectation is that if you're putting the env into nand,
it's going to get read, so you might as well initialize it.
-mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
