On Monday, October 11, 2010 17:27:33 Scott Wood wrote: > On Mon, 11 Oct 2010 17:02:00 -0400 Mike Frysinger wrote: > > On Monday, October 11, 2010 16:29:41 Scott Wood wrote: > > > On Sun, Oct 10, 2010 at 06:37:40AM -0400, Mike Frysinger wrote: > > > > --- a/common/cmd_nand.c > > > > +++ b/common/cmd_nand.c > > > > @@ -309,6 +309,8 @@ > > > > > > > > if (argc < 2) > > > > > > > > goto usage; > > > > > > > > + nand_init(); > > > > + > > > > > > Also do_nandboot(). > > > > does it need to be before the mtdparts init stuff, or can it be in > > nand_load_image() ? > > I think before -- the mtdparts init checks whether an mtd device > actually exists. Though in that case, and also for things > like mtdparts.spread, nand_init() should go in mtdparts_init(), and also > nand_load_image() in case mtdparts aren't enabled.
np > OTOH, I'm fine with leaving that as a future refinement for someone who > is using embedded-env with NAND and cares about the boot time it adds. i'd lean towards this too. i have no way of testing this behavior. -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
