Dear Alexander Stein, Am 01.11.2010 um 09:29 schrieb Alexander Stein: > Signed-off-by: Alexander Stein <alexander.st...@systec-electronic.com> > --- > arch/arm/include/asm/arch-at91/memory-map.h | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/include/asm/arch-at91/memory-map.h > b/arch/arm/include/asm/arch-at91/memory-map.h > index f605f37..dd42bec 100644 > --- a/arch/arm/include/asm/arch-at91/memory-map.h > +++ b/arch/arm/include/asm/arch-at91/memory-map.h > @@ -26,10 +26,10 @@ > > #include <asm/arch/hardware.h> > > -#define USART0_BASE AT91_USART0 > -#define USART1_BASE AT91_USART1 > -#define USART2_BASE AT91_USART2 > -#define USART3_BASE (AT91_BASE_SYS + AT91_DBGU) > +#define USART0_BASE AT91_USART0_BASE > +#define USART1_BASE AT91_USART1_BASE > +#define USART2_BASE AT91_USART2_BASE > +#define USART3_BASE AT91_DBGU_BASE > #define SPI0_BASE AT91_BASE_SPI
can we just drop these definitions? Not to criticize your patch but this is on my todo list, I just hate this USART3->DBGU redefinition. RFC: I would like to get rid of the three time definition/translation of these AT91 USART stuff. The board config include uses CONFIG_USARTx, the atmel_usart.c use this definition to get USART_BASE/USART_ID out of some other definitions in asm/arch/hardware.h and asm/arch/memory-map.h which are also re-definitions of some other values in the respective SOC header files. But beware, avr32 uses the same driver and needs to be changed in the same way. A nice solution could be to define USART_BASE/USART_ID in respective board config files directly and get rid of the re-definitions in hardware.h/memory-map.h regards Andreas Bießmann _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot