Hi Gaurav, On Tue, 19 Oct 2021 at 00:40, Gaurav Jain <gaurav.j...@nxp.com> wrote: > > Hi Simon > > > -----Original Message----- > > From: Simon Glass <s...@chromium.org> > > Sent: Thursday, October 14, 2021 8:40 PM > > To: Gaurav Jain <gaurav.j...@nxp.com> > > Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Stefano Babic > > <sba...@denx.de>; Fabio Estevam <feste...@gmail.com>; Peng Fan > > <peng....@nxp.com>; Priyanka Jain <priyanka.j...@nxp.com>; Ye Li > > <ye...@nxp.com>; Horia Geanta <horia.gea...@nxp.com>; Ji Luo > > <ji....@nxp.com>; Franck Lenormand <franck.lenorm...@nxp.com>; Silvano Di > > Ninno <silvano.dini...@nxp.com>; Sahil Malhotra <sahil.malho...@nxp.com>; > > Pankaj Gupta <pankaj.gu...@nxp.com>; Varun Sethi <v.se...@nxp.com>; dl- > > uboot-imx <uboot-...@nxp.com>; Shengzhou Liu <shengzhou....@nxp.com>; > > Mingkai Hu <mingkai...@nxp.com>; Rajesh Bhagat <rajesh.bha...@nxp.com>; > > Meenakshi Aggarwal <meenakshi.aggar...@nxp.com>; Wasim Khan > > <wasim.k...@nxp.com>; Alison Wang <alison.w...@nxp.com>; Pramod > > Kumar <pramod.kuma...@nxp.com>; Andy Tang <andy.t...@nxp.com>; > > Adrian Alonso <adrian.alo...@nxp.com>; Vladimir Oltean <olte...@gmail.com> > > Subject: [EXT] Re: [PATCH v3 01/16] crypto/fsl: Add support for CAAM Job > > ring > > driver model > > > > Caution: EXT Email > > > > Hi, > > > > On Mon, 4 Oct 2021 at 23:40, Gaurav Jain <gaurav.j...@nxp.com> wrote: > > > > > > added device tree support for job ring driver. > > > sec is initialized based on job ring information processed from device > > > tree. > > > > > > Signed-off-by: Gaurav Jain <gaurav.j...@nxp.com> > > > Reviewed-by: Ye Li <ye...@nxp.com> > > > --- > > > cmd/Kconfig | 1 + > > > drivers/crypto/fsl/Kconfig | 7 + > > > drivers/crypto/fsl/Makefile | 3 +- > > > drivers/crypto/fsl/jr.c | 318 ++++++++++++++++++++++++------------ > > > drivers/crypto/fsl/jr.h | 14 ++ > > > 5 files changed, 233 insertions(+), 110 deletions(-) > > > > This does not look like a proper driver to me, as it has an exported > > function > > sec_init_idx(). > > > > What operations does it perform? Should it have a uclass? > > > > Regards, > > Simon > > For majority of platforms driver model is followed. > But due to memory constraints with few platforms, driver model cannot be > implemented on SPL. > so to enable caam on such platforms we are using non DM approach( via > sec_init_idx() ). > > sec_init_idx() perform tasks that are required for CAAM to work. > caam reset, caam initialization, job ring initialization, RNG instantiation.
OK. BTW have you tried using of-platdata? Regards, Simon
