On Wed, 8 Dec 2021 20:48:54 +0330 Javad Rahimi <javad321ja...@gmail.com> wrote:
> On Wed, Dec 8, 2021 at 8:33 PM Andre Przywara <andre.przyw...@arm.com> wrote: > > > > On Wed, 8 Dec 2021 19:14:22 +0330 > > Javad Rahimi <javad321ja...@gmail.com> wrote: > > > > > On Wed, Dec 8, 2021 at 6:05 PM Andre Przywara <andre.przyw...@arm.com> > > > wrote: > > > > > > > > On Wed, 8 Dec 2021 15:25:54 +0100 > > > > Frank Wunderlich <fran...@public-files.de> wrote: > > > > > > > > Hi, > > > > > > > > > you should add maintainer email for your patch > > > > > > > > > > $ scripts/get_maintainer.pl board/sunxi/board.c > > > > > Jagan Teki <ja...@amarulasolutions.com> (maintainer:ARM SUNXI) > > > > > Andre Przywara <andre.przyw...@arm.com> (maintainer:ARM SUNXI) > > > > > u-boot@lists.denx.de (open list) > > > > > > > > Thanks Frank! > > > > > > > > > > Gesendet: Mittwoch, 08. Dezember 2021 um 15:22 Uhr > > > > > > Von: "Javad Rahimi" <javad321ja...@gmail.com> > > > > > > An: u-boot@lists.denx.de > > > > > > Cc: "Javad Rahimi" <javad321ja...@gmail.com> > > > > > > Betreff: [PATCH v2] Cubieboard2:SUN7I:Add LED BOOT support > > > > > > > > > > > > This feature makes it possible to assign one of > > > > > > LED1(PH20) and LED2(PH21) to BOOT process LED. > > > > > > User should activates the "Enable status LED API" in > > > > > > "Device Drivers -> LED Support" > > > > > > > > Please have a look at the current pinephone_defconfig, because that uses > > > > the boot LED already in a much easier fashion: > > > > https://source.denx.de/u-boot/u-boot/-/commit/0534153fd1 > > > > > > > > Cheers, > > > > Andre > > > > > > > Hi Andre, > > > Thanks for your comments. I studied the pinephone_defconfig. > > > By default, when activating the same options on Cubieboard2_defconfig > > > it shows linker error for `__led_init` and `__led_set`. > > > In other words, they are not defined. So, in this patch, I added the > > > implementation for these functions for this board. > > > > Did you add the: > > CONFIG_SPL_DRIVERS_MISC=y > > line as well? And re-ran make Cubieboard2_defconfig? > > Because that seemed to work for me. > > > > Cheers, > > Andre > > > > > When I add CONFIG_SPL_DRIVERS_MISC=y > By flashing SD card and turning on the board, It freezes in this step: > ``` > U-Boot SPL 2022.01-rc3-00025-gf570594bc9-dirty (Dec 08 2021 - 20:36:51 +0330) > ``` > ----------------------------------------- > The customized defconfig file for Cubieboard: > ``` > CONFIG_ARM=y > CONFIG_ARCH_SUNXI=y > CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-cubieboard2" > CONFIG_SPL_DRIVERS_MISC=y > CONFIG_SPL=y > CONFIG_MACH_SUN7I=y > CONFIG_DRAM_CLK=480 > CONFIG_MMC0_CD_PIN="PH1" > CONFIG_SATAPWR="PB8" > CONFIG_AHCI=y > # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set > CONFIG_SPL_I2C=y > CONFIG_SCSI_AHCI=y > CONFIG_SYS_I2C_MVTWSI=y > CONFIG_SYS_I2C_SLAVE=0x7f > CONFIG_SYS_I2C_SPEED=400000 > CONFIG_PHY_REALTEK=y > CONFIG_ETH_DESIGNWARE=y > CONFIG_MII=y > CONFIG_SUN7I_GMAC=y > CONFIG_SCSI=y > CONFIG_USB_EHCI_HCD=y > CONFIG_USB_OHCI_HCD=y > CONFIG_LED_STATUS=y > CONFIG_LED_STATUS_GPIO=y > CONFIG_LED_STATUS0=y > CONFIG_LED_STATUS_BIT=114 This is the GPIO number, you need to adjust this to point to the pin your LED is connected to. PH20 would be 244, for instance: ('H' - 'A') * 32 + 20 Cheers, Andre > CONFIG_LED_STATUS_STATE=2 > ``` > Best Regards, > Javad > > > > > > > > > > > > Signed-off-by: Javad Rahimi <javad321ja...@gmail.com> > > > > > > --- > > > > > > This is my first contributation in open source world. > > > > > > I'm sorry if I have mistakes in my commits and versioning. > > > > > > I do my best to learn fast. > > > > > > > > > > > > Changes in v2: > > > > > > - Missed braces added > > > > > > - Unnecessary debug removed > > > > > > - Some typo fixed > > > > > > > > > > > > board/sunxi/board.c | 49 > > > > > > +++++++++++++++++++++++++++++++++++++++++++++ > > > > > > 1 file changed, 49 insertions(+) > > > > > > > > > > > > diff --git a/board/sunxi/board.c b/board/sunxi/board.c > > > > > > index 4f5747c34a..5e2f6ae902 100644 > > > > > > --- a/board/sunxi/board.c > > > > > > +++ b/board/sunxi/board.c > > > > > > @@ -1002,3 +1002,52 @@ int board_fit_config_name_match(const char > > > > > > *name) > > > > > > return ret; > > > > > > } > > > > > > #endif > > > > > > + > > > > > > +#if defined(CONFIG_LED_STATUS) && defined(CONFIG_LED_STATUS_BOOT) > > > > > > && defined(CONFIG_LED_STATUS_BOARD_SPECIFIC) > > > > > > + > > > > > > +#define CUBIE2_LED_BOOT_GPIO "PH20" > > > > > > +static int gpio_boot_led; > > > > > > + > > > > > > +void __led_init(led_id_t mask, int state) > > > > > > +{ > > > > > > + int ret; > > > > > > + > > > > > > + if (mask != CONFIG_LED_STATUS_BOOT) > > > > > > + return; > > > > > > + > > > > > > + ret = gpio_lookup_name(CUBIE2_LED_BOOT_GPIO, NULL, NULL, > > > > > > &gpio_boot_led); > > > > > > + > > > > > > + if (ret) > > > > > > + return; > > > > > > + > > > > > > + ret = gpio_request(gpio_boot_led, "boot_led"); > > > > > > + if (ret == -1) { > > > > > > + debug("[gpio_request] Error:%d\n", ret); > > > > > > + return; > > > > > > + } > > > > > > + > > > > > > + ret = gpio_direction_output(gpio_boot_led, 1); > > > > > > + if (ret == -1) { > > > > > > + debug("[gpio_direction_output] Error:%d\n", ret); > > > > > > + return; > > > > > > + } > > > > > > + __led_set(mask, state); > > > > > > +} > > > > > > + > > > > > > +void __led_set(led_id_t mask, int state) > > > > > > +{ > > > > > > + if (mask != CONFIG_LED_STATUS_BOOT) > > > > > > + return; > > > > > > + > > > > > > + gpio_set_value(gpio_boot_led, state); > > > > > > +} > > > > > > + > > > > > > +void __led_toggle(led_id_t mask) > > > > > > +{ > > > > > > + if (mask != CONFIG_LED_STATUS_BOOT) > > > > > > + return; > > > > > > + > > > > > > + gpio_set_value(gpio_boot_led, !gpio_get_value(gpio_boot_led)); > > > > > > +} > > > > > > + > > > > > > +#endif > > > > > > -- > > > > > > 2.25.1 > > > > > > > > > > > > > > > > > >