On Fri, Feb 11, 2022 at 09:47:52PM +0200, Andy Shevchenko wrote: > On Fri, Feb 11, 2022 at 12:31:46PM -0700, Simon Glass wrote: > > On Fri, 11 Feb 2022 at 12:29, Andy Shevchenko <andy.shevche...@gmail.com> > > wrote: > > > On Fri, Feb 11, 2022 at 9:26 PM Simon Glass <s...@chromium.org> wrote: > > > > On Fri, 11 Feb 2022 at 11:28, Andy Shevchenko > > > > <andriy.shevche...@intel.com> wrote: > > > > > On Mon, Jan 31, 2022 at 05:59:30PM -0500, Tom Rini wrote: > > > > > > ... > > > > > > > FWIW here is my tboot flash script for Edison: > > > > > > This is rather unbriking script, DFU (luckily) works > > > > Not if it is bricked: :-) I need something that always works. > > > > > > > > > def flash_edison(self, repo): > > > > vid = 0x8086 > > > > pid = 0xe005 > > > > expect = "%04x:%04x" % (vid, pid) > > > > self.wait_for_dfu(expect) > > > > u_boot = os.path.join(repo._local_str(), "u-boot-edison.img") > > > > bindir = self.usbboot_xfstk_dir > > > > self.host.exec0( > > > > "xfstk-dldr-solo", "--gpflags", "0x80000007", > > > > "--osimage", u_boot, > > > > "--fwdnx", os.path.join(bindir, "edison_dnx_fwr.bin"), > > > > "--fwimage", os.path.join(bindir, "edison_ifwi-dbg-00.bin"), > > > > "--osdnx", os.path.join(bindir, "edison_dnx_osr.bin")) > > > > > > To the topic, any suggestions on how to fix the current U-Boot regression? > > > > The easiest thing is to use 'acpi list' and 'acpi dump facp' etc. to > > see what is different between the two commits. My testing was on coral > > and minnowmax and I must have missed it. We don't actually have any > > test coverage on the board-specific code. > > => acpi dump facp > Table 'FACP' not found > > This explains I believe everything.
Side question(s): - Why out of a sudden different name here: ACPI_WRITER(5fadt, "FACS", apl_write_fadt, 0); FACS vs FACP - Why do you need double assignment of the same revision in acpi_fadt_common() header->revision = 4; ... /* Use ACPI 3.0 revision */ fadt->header.revision = 4; -- With Best Regards, Andy Shevchenko