On Wednesday, December 08, 2010 05:02:38 Wolfgang Denk wrote: > Mike Frysinger wrote: > > unless i'm missing something, the non-reentrant versions operate on a > > single shared hash table. so while this works today because there is > > only one > > Correct. > > > consumer (the env code), wont this cause problems as soon as someone else > > tries to use the non-reentrant hash table code ? as such, wouldnt it > > make sense to punt all of the non-reentrant versions and thus force > > everyone to maintain their own "struct hsearch_data" instance ? > > This could be done, but I don't see an immediate need.
off the top of my head: - it isnt obvious to people today that this issue exists, so anyone attempting to use the fun new hashtable code could conceivably use it without running into a problem (as long as their keys dont happen to collide with env names). so people could possibly waste quite a bit of their time trying to track down bugs that only crop up when certain env vars are set. - i imagine a bit of space is being wasted here. - i re-implemented env-autocomplete, but i need access to the hashtable structure where everything is stored. -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot