Peng, On 5/4/22 16:30, Ariel D'Alessandro wrote: > Hi Peng, > > On 5/3/22 12:43, Tim Harvey wrote: >> On Tue, May 3, 2022 at 4:39 AM Peng Fan (OSS) <peng....@oss.nxp.com> wrote: >>> >>> From: Peng Fan <peng....@nxp.com> >>> >>> Some SPL definitions could be gerneralized, so use imx8m.h for iMX8MN. >>> >> >> Peng, >> >> s/gerneralized/generalized >> >> (looks like that typo is all the patches in your series) >> >> Great cleanup - thanks! This is a great start to getting rid of the >> remaining items in the config headers. >> >> If you do end up doing a 2nd version you can probably remove the >> comments on the sizes, for example 'SZ_8K /* 8 KB */'' as I think the >> comment is not needed. >> >> Works great for imx8mn-venice-*. >> >> Tested-by: Tim Harvey <thar...@gateworks.com> #imx8mm-venice-* > > Thanks a lot for the cleanup! I agree with Tim's comments, would be > worth removing those redundant sizes comments. > > Tested on i.MX8MN BSH SMM S2 PRO board. > Tested-by: Ariel D'Alessandro <ariel.dalessan...@collabora.com>
Tested on i.MX8MN Variscite Symphony board Tested-by: Ariel D'Alessandro <ariel.dalessan...@collabora.com> > >> >>> Signed-off-by: Peng Fan <peng....@nxp.com> >>> --- >>> include/configs/imx8m.h | 10 ++++++++++ >>> include/configs/imx8mn_bsh_smm_s2_common.h | 17 +---------------- >>> include/configs/imx8mn_evk.h | 20 +------------------- >>> include/configs/imx8mn_var_som.h | 15 +-------------- >>> include/configs/imx8mn_venice.h | 18 +----------------- >>> 5 files changed, 14 insertions(+), 66 deletions(-) > > [snip]
