Hi Stefan, On Tue, Aug 30, 2022 at 11:19 PM Stefan Roese <s...@denx.de> wrote: > > Hi Tony, > > On 31.08.22 07:08, Stefan Roese wrote: > > Hi Tony, > > > > On 31.08.22 07:02, Stefan Roese wrote: > >> Hi Tony, > >> > >> On 31.08.22 00:15, Tony Dinh wrote: > >>> Hi Stefan, > >>> > >>> On Tue, Aug 30, 2022 at 4:53 AM Stefan Roese <s...@denx.de> wrote: > >>>> > >>>> This patchset enhaces the recently added Orion Timer driver to support > >>>> all other Kirkwood & 32bit MVEBU Armada platforms. Additionally, this > >>>> timer support is then enabled per default for those platforms, so that > >>>> the board config files don't need to be changed. Also necessary is > >>>> some dts hacking, so that the timer DT node is available in early > >>>> U-Boot stages. > >>>> > >>>> I've successfully tested this patchset on an Armada XP board. > >>>> Additional > >>>> test on other boards and platforms are very welcome and necessary. > >>> > >>> I've run some tests with the following 2 Kirkwood boards: Cloud > >>> Engines Pogo V4 88F6192 (with CONFIG_DM_RTC and CONFIG_RTC_EMULATION), > >>> and Marvell Sheevaplug 88F6281 (with CONFIG_DM_RTC and CONFIG_RTC_MV). > >>> > >>> It seems that it was either frozen or the timer did not expire at some > >>> subsequent sleep commands. Sometime it happened at 2nd command, some > >>> time at a later sleep command. For example, > >>> > >>> === Pogo V4 (the 1st sleep command works correctly at 10 seconds on my > >>> stopwatch) > >>> > >>> U-Boot 2022.10-rc3-00048-g66ccd87a9c-dirty (Aug 30 2022 - 13:38:24 > >>> -0700) > >>> Pogoplug V4 > >>> > >>> Hit any key to stop autoboot: 0 > >>> Pogo_V4> sleep 10 > >>> Pogo_V4> sleep 31.5 > >>> <frozen here> > >> > >> Does the cmd interface support fractial numbers? Please test again with > >> 31 or other integral numbers. > >> > >>> === Sheevaplug (RTC battery is old, so the date was not updated, but > >>> the clock seems OK) > >>> > >>> U-Boot 2022.10-rc3-00048-g66ccd87a9c-dirty (Aug 30 2022 - 14:14:24 > >>> -0700) > >>> Marvell-Sheevaplug > >>> Hit any key to stop autoboot: 0 > >>> => date > >>> Date: 2000-01-01 (Saturday) Time: 0:02:55 > >>> => sleep 10 > >>> => date > >>> Date: 2000-01-01 (Saturday) Time: 0:03:18 > >>> => sleep 10 > >>> => sleep 20.1 > >>> <frozen here> > >>> > >>> Please let me know what I can do (i.e. perhaps running a debug patch). > >> > >> Please see above. I assume that the fractional numbers result in very > >> long numbers internally, which result in a frozen / hanging system. > > > > I just tested fractional numbers on another board and hey, it just > > works. Learned something new. So we seem to have a problem here. Let > > me see, if I can find something. > > I can't reproduce this problem on my Armada XP platform. When your > system is frozen, can you interrupt the sleep cmd via Ctrl-C? Can you > please also test without this patchset applied, if a series of sleep > commands works fine there?
Indeed, it works without the patchset. I ran an older version (U-Boot 2021.10) and entered some random sleep periods such as Pogo_V4> sleep 5 Pogo_V4> sleep 20.5 Pogo_V4> sleep 35 Pogo_V4> sleep 15.3 Pogo_V4> sleep 33.33 Pogo_V4> sleep 77.23 And it is also true that I could not do Ctrl-C when it is frozen running with the new timer. Thanks, Tony > Thanks, > Stefan