Dear Aneesh V, In message <1293018898-13253-7-git-send-email-ane...@ti.com> you wrote: > adapt omap4 to the new layered cache maintenance framework > > Signed-off-by: Aneesh V <ane...@ti.com>
> +/* > + * Outer cache related functions > + */ > +#ifndef CONFIG_SYS_NO_DCACHE Do we really need such a #define? Where is CONFIG_SYS_NO_DCACHE documented? > +void v7_setup_outer_cache_ops(void) > +{ > +#ifndef CONFIG_L2_OFF Should this be CONFIG_L2_OFF or CONFIG_SYS_L2_OFF? Where is CONFIG_SYS_L2_OFF documented? > @@ -45,3 +47,18 @@ lowlevel_init: > */ > bl s_init > pop {ip, pc} > + > +set_pl310_ctrl_reg: > + PUSH {r4-r11, lr} @ save registers - ROM code may pollute > + @ our registers > + LDR r12, =0x102 @ Set PL310 control register - value in R0 > + SMC #0 @ call ROM Code API to set control register > + POP {r4-r11, pc} Indentation by TAB, please. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de It's not an optical illusion, it just looks like one. -- Phil White _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot