Re: [PATCH v3 16/17] riscv: dts: jh7110: Add initial StarFive VisionFive v2 board device tree

[yanhong wang]

On 2023/3/4 5:20, Conor Dooley wrote:
> On Fri, Mar 03, 2023 at 11:24:31AM +0800, Yanhong Wang wrote:
>> Add initial device tree for StarFive VisionFive v2 board.
>> 
>> Signed-off-by: Yanhong Wang <yanhong.w...@starfivetech.com>
>> ---
>>  arch/riscv/dts/Makefile                       |   3 +-
>>  ...10-starfive-visionfive-2-v1.2a-u-boot.dtsi |  85 ++++++
>>  .../jh7110-starfive-visionfive-2-v1.2a.dts    |  12 +
>>  ...10-starfive-visionfive-2-v1.3b-u-boot.dtsi |  85 ++++++
>>  .../jh7110-starfive-visionfive-2-v1.3b.dts    |  12 +
>>  .../dts/jh7110-starfive-visionfive-2.dtsi     | 253 ++++++++++++++++++
>>  6 files changed, 449 insertions(+), 1 deletion(-)
>>  create mode 100644 
>> arch/riscv/dts/jh7110-starfive-visionfive-2-v1.2a-u-boot.dtsi
>>  create mode 100644 arch/riscv/dts/jh7110-starfive-visionfive-2-v1.2a.dts
>>  create mode 100644 
>> arch/riscv/dts/jh7110-starfive-visionfive-2-v1.3b-u-boot.dtsi
>>  create mode 100644 arch/riscv/dts/jh7110-starfive-visionfive-2-v1.3b.dts
>>  create mode 100644 arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi
> 
>> diff --git a/arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi 
>> b/arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi
>> new file mode 100644
>> index 0000000000..e669c2a26a
>> --- /dev/null
>> +++ b/arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi
>> @@ -0,0 +1,253 @@
>> +// SPDX-License-Identifier: GPL-2.0 OR MIT
>> +/*
>> + * Copyright (C) 2022 StarFive Technology Co., Ltd.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "jh7110.dtsi"
>> +#include <dt-bindings/pinctrl/pinctrl-starfive-jh7110.h>
>> +/ {
>> +    aliases {
>> +            serial0 = &uart0;
>> +            spi0 = &qspi;
>> +            mmc0 = &mmc0;
>> +            mmc1 = &mmc1;
>> +    };
>> +
>> +    chosen {
>> +            stdout-path = "serial0:115200";
>> +    };
>> +
>> +    cpus {
>> +            timebase-frequency = <4000000>;
>> +    };
>> +
>> +    memory@40000000 {
>> +            device_type = "memory";
>> +            reg = <0x0 0x40000000 0x2 0x0>;
>> +    };
>> +};
>> +
> 
>> +&S7_0 {
>> +    status = "okay";
>> +};
> 
> Please forgive me if I am missing something obvious, but should this be
> be in -u-boot.dtsi instead?
> 

Thanks. I will move this node to -u-boot.dtsi.

> Cheers,
> Conor.