On 2023/3/23 16:31, Andreas Schwab wrote:
> On Mär 22 2023, yanhong wang wrote:
>
>> On 2023/3/21 21:51, Andreas Schwab wrote:
>>> On Mär 21 2023, yanhong wang wrote:
>>>
>>>> Except for CONFIG_DEFAULT_DEVICE_TREE and CONFIG_DEFAULT_FDT_FILE,
>>>> 1.2a and 1.3b versions use the same config.
>>>>
>>>> Version 1.3b uses the following configuration:
>>>> CONFIG_DEFAULT_DEVICE_TREE="jh7110-starfive-visionfive-2-v1.3b"
>>>>
>>>> CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2-v1.3b.dtb"
>>>>
>>>> Version 1.2a uses the following configuration:
>>>> CONFIG_DEFAULT_DEVICE_TREE="jh7110-starfive-visionfive-2-v1.2a"
>>>>
>>>> CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2-v1.2a.dtb"
>>>>
>>>> Is it necessary to separate the configs for 1.2a and 1.3b as separate
>>>> defconfig files?
>>>
>>> It makes a difference for when ethernet support is added.
>>>
>>
>> The difference between 1.2a and 1.3b versions is mainly in ethernet, so the
>> definition of
>> dts is separated. Defconfig file in addition to the differences mentioned
>> above, the others
>> are the same. Your suggestion is to define defconfig file separately, is
>> that right?
>
> Yes, a 1.2a board will need to use the 1.2a device tree to get a working
> ethernet, IIUC.
>
Okay, I will define the defconfig for 1.2A and 1.3B separately in the next
version.