Hi Bin, On Wed, 12 Jul 2023 at 05:58, Bin Meng <bmeng...@gmail.com> wrote: > > Hi Simon, > > On Tue, Jun 20, 2023 at 4:23 PM Simon Glass <s...@chromium.org> wrote: > > > > Drop IDE since this is not widely used anymore. Add NVME since it is > > becoming more popular. > > > > Add ms so it is easier to search for tables in memory. > > > > Expand the command-line and print buffers so that we can deal with the > > very long ChromeOS command lines. (typically 700 characters). > > > > Enable BOOTSTD_FULL to get the full set up standard-boot options. > > > > Finally, expand the malloc() space so we can read large kernels into a > > bootflow. > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > --- > > > > (no changes since v1) > > > > configs/coreboot_defconfig | 16 ++++------------ > > 1 file changed, 4 insertions(+), 12 deletions(-) > > > > diff --git a/configs/coreboot_defconfig b/configs/coreboot_defconfig > > index 058caf008f9a..e650fca572f9 100644 > > --- a/configs/coreboot_defconfig > > +++ b/configs/coreboot_defconfig > > @@ -1,5 +1,6 @@ > > CONFIG_X86=y > > CONFIG_TEXT_BASE=0x1110000 > > +CONFIG_SYS_MALLOC_LEN=0x2000000 > > CONFIG_NR_DRAM_BANKS=8 > > CONFIG_ENV_SIZE=0x1000 > > CONFIG_DEFAULT_DEVICE_TREE="coreboot" > > @@ -8,12 +9,11 @@ CONFIG_VENDOR_COREBOOT=y > > CONFIG_TARGET_COREBOOT=y > > CONFIG_FIT=y > > CONFIG_FIT_SIGNATURE=y > > +CONFIG_BOOTSTD_FULL=y > > CONFIG_SYS_MONITOR_BASE=0x01110000 > > CONFIG_SHOW_BOOT_PROGRESS=y > > CONFIG_USE_BOOTARGS=y > > CONFIG_BOOTARGS="root=/dev/sdb3 init=/sbin/init rootwait ro" > > -CONFIG_USE_BOOTCOMMAND=y > > -CONFIG_BOOTCOMMAND="ext2load scsi 0:3 01000000 /boot/vmlinuz; zboot > > 01000000" > > CONFIG_PRE_CONSOLE_BUFFER=y > > CONFIG_SYS_CONSOLE_INFO_QUIET=y > > CONFIG_LOG=y > > @@ -23,9 +23,6 @@ CONFIG_DISPLAY_BOARDINFO_LATE=y > > CONFIG_LAST_STAGE_INIT=y > > CONFIG_PCI_INIT_R=y > > CONFIG_HUSH_PARSER=y > > -CONFIG_SYS_PBSIZE=532 > > -CONFIG_CMD_MEM_SEARCH=y > > -CONFIG_CMD_IDE=y > > CONFIG_CMD_MMC=y > > CONFIG_CMD_PART=y > > CONFIG_CMD_USB=y > > @@ -53,13 +50,8 @@ CONFIG_USE_ROOTPATH=y > > CONFIG_REGMAP=y > > CONFIG_SYSCON=y > > # CONFIG_ACPIGEN is not set > > -CONFIG_SYS_IDE_MAXDEVICE=4 > > -CONFIG_SYS_ATA_DATA_OFFSET=0 > > -CONFIG_SYS_ATA_REG_OFFSET=0 > > -CONFIG_SYS_ATA_ALT_OFFSET=0 > > -CONFIG_ATAPI=y > > -CONFIG_LBA48=y > > -CONFIG_SYS_64BIT_LBA=y > > +CONFIG_MISC=y > > +CONFIG_NVMEM=y > > Are these 2 needed? > > CONFIG_MISC=y > CONFIG_NVMEM=y
I thought they were but can't remember why. I'll drop them for now. > > > CONFIG_NVME_PCI=y > > # CONFIG_PCI_PNP is not set > > CONFIG_SOUND=y > > -- > Regards, Simon