Hi Bin,
On Thu, 13 Jul 2023 at 04:50, Bin Meng <bmeng...@gmail.com> wrote:
>
> Hi Simon,
>
> On Mon, Jun 19, 2023 at 8:02 PM Simon Glass <s...@chromium.org> wrote:
> >
> > Add the required tag so that micron memory can be set up correctly.
> >
> > Signed-off-by: Simon Glass <s...@chromium.org>
> > ---
> >
> > (no changes since v2)
> >
> > Changes in v2:
> > - Add new patch to support Micron memory
> >
> > arch/x86/dts/chromebook_link.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/x86/dts/chromebook_link.dts
> > b/arch/x86/dts/chromebook_link.dts
> > index 36956f40bd70..c904b7d0b69d 100644
> > --- a/arch/x86/dts/chromebook_link.dts
> > +++ b/arch/x86/dts/chromebook_link.dts
> > @@ -314,6 +314,7 @@
> > 00 00 00 00 00 00 00 00];
> > };
> > micron_4Gb_1600_1.35v_x16 {
> > + bootph-all;
>
> This property does not look good to me. I believe the right name
> should add a "u-boot" prefix here.
The U-Boot schema was upstreamed to Linux recently [1] and this is the
name that was chosen.
>
> > reg = <2>;
> > data = [92 11 0b 03 04 19 02 02
> > 03 11 01 08 0a 00 fe 00
> > --
>
> Anyway,
> Reviewed-by: Bin Meng <bmeng...@gmail.com>
>
> Regards,
> Bin
Regards,
Simon
[1]
https://github.com/robherring/dt-schema/commit/53ca8c9554c445cadaae02f030b56211f39d8c44
