Hi Bin, On Thu, 13 Jul 2023 at 04:49, Bin Meng <bmeng...@gmail.com> wrote: > > Hi Simon, > > On Mon, Jun 19, 2023 at 8:02 PM Simon Glass <s...@chromium.org> wrote: > > > > At present it is not possible to read from some CDROM drives since the > > FAT sector size does not match the media's block size. Add a conversion > > option for this, so that reading is possible. > > I am completely confused. The CDROM uses iso9660 file system. This has > nothing to do with FAT.
It actually can use both - this is the -cdrom option in QEMU which can emulate an old-style CDROM, with a FAT filesystem on it! > > > > > This does increase SPL size for read-only FAT support by 25 bytes but > > all but 6 are covered by the previous patch. We could reduce the > > overhead of this feature to 0 bytes by making the code uglier (using > > a static variable). > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > --- > > > > (no changes since v2) > > > > Changes in v2: > > - Use log_warning() for the warning > > > > fs/fat/Kconfig | 13 ++++++ > > fs/fat/fat.c | 107 ++++++++++++++++++++++++++++++++++++++++----- > > fs/fat/fat_write.c | 8 ++-- > > 3 files changed, 114 insertions(+), 14 deletions(-) Regards, Simon