Re: [PATCH 4/5] clk: rockchip: rk3568: Add dummy support for GMAC speed clocks

[Kever Yang]

On 2023/8/4 17:34, Jonas Karlman wrote:

Pine64 Quartz64 boards DT reference SCLK_GMAC1_RGMII_SPEED in the
assigned-clocks property of the gmac1 node. This result in a ENOENT
error when driver core tries to set a parent for this clock.

The clock speed in rgmii/rmii mode is changed using clk_set_rate of the
tx_rx clock and not using clk_set_parent of the speed clock.

Add dummy support for SCLK_GMAC1_RGMII_SPEED and similar clocks to clk
driver to allow a driver for gmac node to probe.

Signed-off-by: Jonas Karlman <jo...@kwiboo.se>

Reviewed-by: Kever Yang <kever.y...@rock-chips.com>

Thanks,
- Kever

---
  drivers/clk/rockchip/clk_rk3568.c | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/drivers/clk/rockchip/clk_rk3568.c 
b/drivers/clk/rockchip/clk_rk3568.c
index dabc7e70dd5a..599b7b130eb9 100644
--- a/drivers/clk/rockchip/clk_rk3568.c
+++ b/drivers/clk/rockchip/clk_rk3568.c
@@ -2843,6 +2843,10 @@ static int rk3568_clk_set_parent(struct clk *clk, struct 
clk *parent)
        case CLK_RKVDEC_CORE:
                return rk3568_rkvdec_set_parent(clk, parent);
        case I2S1_MCLKOUT_TX:
+       case SCLK_GMAC0_RGMII_SPEED:
+       case SCLK_GMAC0_RMII_SPEED:
+       case SCLK_GMAC1_RGMII_SPEED:
+       case SCLK_GMAC1_RMII_SPEED:
                break;
        default:
                return -ENOENT;