Hi Nishanth

On 03/01/24 23:06, Nishanth Menon wrote:
On 00:45-20231220, Apurva Nandan wrote:
Add board-cfg, rm-cfg, pm-cfg, sec-cfg, tifs-rm-cfg yaml for buidling
u-boot sysfw data.

Signed-off-by: Apurva Nandan <a-nan...@ti.com>
---
  board/ti/j784s4/board-cfg.yaml   |   37 +
  board/ti/j784s4/pm-cfg.yaml      |   13 +
  board/ti/j784s4/rm-cfg.yaml      | 3058 ++++++++++++++++++++++++++++++
  board/ti/j784s4/sec-cfg.yaml     |  380 ++++
  board/ti/j784s4/tifs-rm-cfg.yaml | 2656 ++++++++++++++++++++++++++
  5 files changed, 6144 insertions(+)
  create mode 100644 board/ti/j784s4/board-cfg.yaml
  create mode 100644 board/ti/j784s4/pm-cfg.yaml
  create mode 100644 board/ti/j784s4/rm-cfg.yaml
  create mode 100644 board/ti/j784s4/sec-cfg.yaml
  create mode 100644 board/ti/j784s4/tifs-rm-cfg.yaml


Cursory review.. but btw, when I run:
$ yamllint board/ti/j784s4/rm-cfg.yaml

it throws a bunch of warnings, but it does the same for other yamls as
well. Not sure it was supposed to be yamlinted - Neha? Might be good
idea than manual review to ensure some basic checks are done?

Either way,

Reviewed-by: Nishanth Menon <n...@ti.com>


Yeah I didn't have any other checks in place for the YAML files, thanks for noticing this, will target a quick clean up patch.


Ref - I used yamllint 1.26.3

--
Thanking You
Neha Malcom Francis

Reply via email to