On 2024-02-07 06:52, Chen-Yu Tsai wrote: > On Wed, Feb 7, 2024 at 8:04 AM Jonas Karlman <jo...@kwiboo.se> wrote: >> >> Update defconfig for rk3328-roc-cc with new defaults. >> >> Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. >> >> Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash >> of FIT images. This help indicate if there is an issue loading any of >> the images to DRAM or SRAM. Also add LEGACY_IMAGE_FORMAT=y to keep >> support for scripts. >> >> Add ROCKCHIP_EFUSE=y and remove NET_RANDOM_ETHADDR=y, ethaddr and >> eth1addr is set based on cpuid read from eFUSE. > > I wonder if it would make sense to enable ROCKCHIP_EFUSE or ROCKCHIP_OTP > for the respective SoCs by default, either with "imply" under the SoC > Kconfig options, or "default if XXX" under the driver Kconfig options? > Not sure which is preferred. > > Same goes for CONFIG_MISC_INIT_R for actually generating the serial number > and MAC addresses from the efuse/OTP. > > At least for RK3566 and RK3588 we are implying these options.
I agree that these and lots of other Kconfig options could and should be implied, either at soc or arch level. Maybe something for a follow up series? Regards, Jonas > > > ChenYu > >> Add SPL_DM_SEQ_ALIAS=y option to use alias sequence number in SPL. >> >> Add DM_ETH_PHY=y, PHY_MOTORCOMM=y and PHY_REALTEK=y to support common >> ethernet PHYs. >> >> Add RNG_ROCKCHIP=y and DM_RNG=y options to support the onboard random >> generator. >> >> Also add missing device tree file to MAINTAINERS and add myself as a >> reviewer for this board. >> >> Signed-off-by: Jonas Karlman <jo...@kwiboo.se> >> --- >> board/rockchip/evb_rk3328/MAINTAINERS | 2 ++ >> configs/roc-cc-rk3328_defconfig | 9 +++++++-- >> doc/board/rockchip/rockchip.rst | 2 +- >> 3 files changed, 10 insertions(+), 3 deletions(-) >> >> diff --git a/board/rockchip/evb_rk3328/MAINTAINERS >> b/board/rockchip/evb_rk3328/MAINTAINERS >> index 419bc8ded375..09488eaf083f 100644 >> --- a/board/rockchip/evb_rk3328/MAINTAINERS >> +++ b/board/rockchip/evb_rk3328/MAINTAINERS >> @@ -41,8 +41,10 @@ F: >> arch/arm/dts/rk3328-orangepi-r1-plus-lts-u-boot.dtsi >> ROC-RK3328-CC >> M: Loic Devulder <ldevul...@suse.com> >> M: Chen-Yu Tsai <w...@csie.org> >> +R: Jonas Karlman <jo...@kwiboo.se> >> S: Maintained >> F: configs/roc-cc-rk3328_defconfig >> +F: arch/arm/dts/rk3328-roc-cc.dts >> F: arch/arm/dts/rk3328-roc-cc-u-boot.dtsi >> >> ROCK64-RK3328 >> diff --git a/configs/roc-cc-rk3328_defconfig >> b/configs/roc-cc-rk3328_defconfig >> index 4ac3c9403b02..7d81a715ef25 100644 >> --- a/configs/roc-cc-rk3328_defconfig >> +++ b/configs/roc-cc-rk3328_defconfig >> @@ -15,7 +15,6 @@ CONFIG_ROCKCHIP_RK3328=y >> CONFIG_TPL_ROCKCHIP_COMMON_BOARD=y >> CONFIG_TPL_LIBCOMMON_SUPPORT=y >> CONFIG_TPL_LIBGENERIC_SUPPORT=y >> -CONFIG_SPL_DRIVERS_MISC=y >> CONFIG_SPL_STACK_R_ADDR=0x600000 >> CONFIG_SPL_STACK=0x400000 >> CONFIG_TPL_SYS_MALLOC_F_LEN=0x800 >> @@ -26,7 +25,9 @@ CONFIG_DEBUG_UART=y >> # CONFIG_ANDROID_BOOT_IMAGE is not set >> CONFIG_FIT=y >> CONFIG_FIT_VERBOSE=y >> +CONFIG_SPL_FIT_SIGNATURE=y >> CONFIG_SPL_LOAD_FIT=y >> +CONFIG_LEGACY_IMAGE_FORMAT=y >> CONFIG_DEFAULT_FDT_FILE="rockchip/rk3328-roc-cc.dtb" >> # CONFIG_DISPLAY_CPUINFO is not set >> CONFIG_DISPLAY_BOARDINFO_LATE=y >> @@ -58,8 +59,8 @@ CONFIG_TPL_OF_PLATDATA=y >> CONFIG_ENV_IS_IN_MMC=y >> CONFIG_SYS_RELOC_GD_ENV_ADDR=y >> CONFIG_SYS_MMC_ENV_DEV=1 >> -CONFIG_NET_RANDOM_ETHADDR=y >> CONFIG_TPL_DM=y >> +CONFIG_SPL_DM_SEQ_ALIAS=y >> CONFIG_REGMAP=y >> CONFIG_SPL_REGMAP=y >> CONFIG_TPL_REGMAP=y >> @@ -73,9 +74,11 @@ CONFIG_FASTBOOT_CMD_OEM_FORMAT=y >> CONFIG_ROCKCHIP_GPIO=y >> CONFIG_SYS_I2C_ROCKCHIP=y >> CONFIG_MISC=y >> +CONFIG_ROCKCHIP_EFUSE=y >> CONFIG_MMC_DW=y >> CONFIG_MMC_DW_ROCKCHIP=y >> CONFIG_PHY_REALTEK=y >> +CONFIG_DM_ETH_PHY=y >> CONFIG_PHY_GIGE=y >> CONFIG_ETH_DESIGNWARE=y >> CONFIG_GMAC_ROCKCHIP=y >> @@ -95,6 +98,8 @@ CONFIG_PWM_ROCKCHIP=y >> CONFIG_RAM=y >> CONFIG_SPL_RAM=y >> CONFIG_TPL_RAM=y >> +CONFIG_DM_RNG=y >> +CONFIG_RNG_ROCKCHIP=y >> CONFIG_BAUDRATE=1500000 >> CONFIG_DEBUG_UART_SHIFT=2 >> CONFIG_SYS_NS16550_MEM32=y >> diff --git a/doc/board/rockchip/rockchip.rst >> b/doc/board/rockchip/rockchip.rst >> index de2195deadca..99f48b6d6fa5 100644 >> --- a/doc/board/rockchip/rockchip.rst >> +++ b/doc/board/rockchip/rockchip.rst >> @@ -60,8 +60,8 @@ List of mainline supported Rockchip boards: >> - ODROID-GO Advance (odroid-go2) >> * rk3328 >> - Rockchip Evb-RK3328 (evb-rk3328) >> + - Firefly ROC-RK3328-CC (roc-cc-rk3328) >> - Pine64 Rock64 (rock64-rk3328) >> - - Firefly-RK3328 (roc-cc-rk3328) >> - Radxa Rockpi E (rock-pi-e-rk3328) >> * rk3368 >> - GeekBox (geekbox) >> -- >> 2.43.0 >>