On Wed, 21 Feb 2024 at 16:11, Marek Vasut <ma...@denx.de> wrote: > > On 2/21/24 08:55, Francesco Dolcini wrote: > > Hello Sumit, > > > > On Tue, Feb 20, 2024 at 06:40:56PM +0530, Sumit Garg wrote: > >> Also, enable reset driver which is a prerequisite for PCIe support. > >> > >> Signed-off-by: Sumit Garg <sumit.g...@linaro.org> > >> --- > >> configs/verdin-imx8mp_defconfig | 9 +++++++++ > >> 1 file changed, 9 insertions(+) > >> > >> diff --git a/configs/verdin-imx8mp_defconfig > >> b/configs/verdin-imx8mp_defconfig > >> index 22b8a334dfa..d8bd644322b 100644 > >> --- a/configs/verdin-imx8mp_defconfig > >> +++ b/configs/verdin-imx8mp_defconfig > >> @@ -185,3 +185,12 @@ CONFIG_USB_GADGET_VENDOR_NUM=0x1b67 > >> CONFIG_USB_GADGET_PRODUCT_NUM=0x4000 > >> CONFIG_IMX_WATCHDOG=y > >> CONFIG_HEXDUMP=y > >> +CONFIG_DM_RESET=y > >> +CONFIG_RESET_IMX=y > >> +CONFIG_PCI=y > >> +CONFIG_PCIE_DW_IMX8=y > >> +CONFIG_PHY_IMX8M_PCIE=y > >> +CONFIG_CMD_PCI=y > >> +CONFIG_NVME=y > >> +CONFIG_NVME_PCI=y > >> +CONFIG_CMD_NVME=y > > > > This will increase the u-boot proper size and marginally increase the > > boot time (because of a bigger binary to be read from the eMMC). > > > > Apart of that do you expect any other impact on those changes? SPL > > binary size should not be affected, correct? > > > > Asking this out loudly to confirm that nothing unexpected is going to > > happen because of these changes. > > > > For my curiosity, care to share what's the use case? Do you plan to have > > the OS stored into an NVME device? > > Boot OS images from NVMe is useful if eMMC size no longer cuts it > (because debug symbols or to collect logs over long periods of time).
Yeah especially if one wants to run a fully fledged Linux distro image. -Sumit