Hello Leon,
On 2024-03-02 14:17, Leon M. Busch-George wrote:
From: "Leon M. Busch-George" <l...@georgemail.eu>
The error message "bc: command not found" is easily missed since the
build continues.
bc is not a part of coreutils or base-devel. POSIX sh can also do the
calculation.
Signed-off-by: Leon M. Busch-George <l...@georgemail.eu>
Please, see a nitpick below. Otherwise, the patch is looking
good to me.
Reviewed-by: Dragan Simic <dsi...@manjaro.org>
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 7a3209bd9e..41dc4baad2 100644
--- a/Makefile
+++ b/Makefile
@@ -1275,9 +1275,9 @@ OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \
binary_size_check: u-boot-nodtb.bin FORCE
@file_size=$(shell wc -c u-boot-nodtb.bin | awk '{print $$1}') ; \
map_size=$(shell cat u-boot.map | \
- awk '/_image_copy_start/ {start = $$1} /_image_binary_end/ {end
=
$$1} END {if (start != "" && end != "") print "ibase=16; "
toupper(end) " - " toupper(start)}' \
+ awk '/_image_copy_start/ {start = $$1} /_image_binary_end/ {end
=
$$1} END {if (start != "" && end != "") print "echo $$((0x"
toupper(end) " - 0x" toupper(start) "))"}' \
| sed 's/0X//g' \
- | bc); \
+ | sh); \
Maybe "sh -s" could be used instead, just for some additional
strictness.
if [ "" != "$$map_size" ]; then \
if test $$map_size -ne $$file_size; then \
echo "u-boot.map shows a binary size of $$map_size" >&2
; \
