A colleague made me aware that the '[ -n "$$end" ]' is not necessary since
'read' already returns an exit code.
v3 inc
On Mon, 4 Mar 2024 21:38:56 +0100
"Leon M. Busch-George" <l...@georgemail.de> wrote:
> From: "Leon M. Busch-George" <l...@georgemail.eu>
>
> The error message "bc: command not found" is easily missed since the
> build continues.
> bc is not a part of coreutils or base-devel. POSIX sh can also do the
> calculation.
>
> Signed-off-by: Leon M. Busch-George <l...@georgemail.eu>
> ---
> Makefile | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index a2bc9d5903..e8e794368e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1275,10 +1275,15 @@ OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \
> binary_size_check: u-boot-nodtb.bin FORCE
> @file_size=$(shell wc -c u-boot-nodtb.bin | awk '{print
> $$1}') ; \ map_size=$(shell cat u-boot.map | \
> - awk '/_image_copy_start/ {start = $$1}
> /_image_binary_end/ {end = $$1} END {if (start != "" && end != "")
> print "ibase=16; " toupper(end) " - " toupper(start)}' \
> - | sed 's/0X//g' \
> - | bc); \
> - if [ "" != "$$map_size" ]; then \
> + awk ' \
> + /_image_copy_start/ { start = $$1 } \
> + /_image_binary_end/ { end = $$1 } \
> + END { \
> + if (start != "" && end != "") \
> + print end " " start; \
> + }' \
> + | sh -c 'read end start; [ -n "$$end" ] && echo
> $$((end - start))'); \
> + if [ -n "$$map_size" ]; then \
> if test $$map_size -ne $$file_size; then \
> echo "u-boot.map shows a binary size of
> $$map_size" >&2 ; \ echo " but u-boot-nodtb.bin shows $$file_size"
> >&2 ; \
