On Sun, 31 Mar 2024 at 21:30, Jonas Karlman <jo...@kwiboo.se> wrote: > > The rk3399-ficus board is only using SPL and not TPL+SPL like all other > RK3399 boards, chromebook bob/kevin excluded. It does not seem to be any > technical reason why this board was left using only SPL. > > Switch to use TPL+SPL and use common bss and stack addresses to allow > for more options to be enabled in a future patch. Also add the missing > DEFAULT_FDT_FILE option. > > Signed-off-by: Jonas Karlman <jo...@kwiboo.se> Reviewed-by: Peter Robinson <pbrobin...@gmail.com>
I believe I have one of these if you need anything tested. P > --- > configs/ficus-rk3399_defconfig | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/configs/ficus-rk3399_defconfig b/configs/ficus-rk3399_defconfig > index 4859042d6b56..3bcd0fd66b91 100644 > --- a/configs/ficus-rk3399_defconfig > +++ b/configs/ficus-rk3399_defconfig > @@ -2,32 +2,22 @@ CONFIG_ARM=y > CONFIG_SKIP_LOWLEVEL_INIT=y > CONFIG_COUNTER_FREQUENCY=24000000 > CONFIG_ARCH_ROCKCHIP=y > -CONFIG_TEXT_BASE=0x00200000 > -CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > -CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000 > CONFIG_SF_DEFAULT_SPEED=20000000 > CONFIG_ENV_OFFSET=0x3F8000 > CONFIG_DEFAULT_DEVICE_TREE="rk3399-ficus" > -CONFIG_SPL_TEXT_BASE=0xff8c2000 > CONFIG_ROCKCHIP_RK3399=y > -CONFIG_ROCKCHIP_SPL_RESERVE_IRAM=0x4000 > CONFIG_TARGET_ROCK960_RK3399=y > -CONFIG_SPL_STACK=0xff8effff > CONFIG_DEBUG_UART_BASE=0xFF1A0000 > CONFIG_DEBUG_UART_CLOCK=24000000 > CONFIG_SYS_LOAD_ADDR=0x800800 > CONFIG_DEBUG_UART=y > +CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-ficus.dtb" > CONFIG_DISPLAY_BOARDINFO_LATE=y > CONFIG_SPL_MAX_SIZE=0x2e000 > CONFIG_SPL_PAD_TO=0x7f8000 > -CONFIG_SPL_HAS_BSS_LINKER_SECTION=y > -CONFIG_SPL_BSS_START_ADDR=0xff8e0000 > -CONFIG_SPL_BSS_MAX_SIZE=0x10000 > # CONFIG_SPL_RAW_IMAGE_SUPPORT is not set > -# CONFIG_SPL_SHARES_INIT_SP_ADDR is not set > -CONFIG_SPL_STACK_R=y > -CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x4000 > CONFIG_SPL_ATF_NO_PLATFORM_PARAM=y > +CONFIG_TPL=y > CONFIG_CMD_BOOTZ=y > CONFIG_CMD_GPT=y > CONFIG_CMD_MMC=y > -- > 2.43.2 >