On Wed, May 15, 2024 at 05:31:59AM -0700, Raymond Mao wrote: > Move snprintf to stdio.h since it is needed by exteranl libraries. > > Signed-off-by: Raymond Mao <raymond....@linaro.org>
Thanks for doing the work. One problem: > diff --git a/include/stdio.h b/include/stdio.h > index 3241e2d493f..ecd0f996efb 100644 > --- a/include/stdio.h > +++ b/include/stdio.h > @@ -45,6 +45,7 @@ static inline int vprintf(const char *fmt, va_list args) > return 0; > } > #endif > +int snprintf(char *buf, size_t size, const char *fmt, ...); > > /* > * FILE based functions (can only be used AFTER relocation!) > diff --git a/include/vsprintf.h b/include/vsprintf.h > index ed8a060ee17..fe951471426 100644 > --- a/include/vsprintf.h > +++ b/include/vsprintf.h > @@ -218,23 +218,6 @@ char *simple_itoa(ulong val); > */ > char *simple_xtoa(ulong num); > > -/** > - * Format a string and place it in a buffer > - * > - * @buf: The buffer to place the result into > - * @size: The size of the buffer, including the trailing null space > - * @fmt: The format string to use > - * @...: Arguments for the format string > - * Return: the number of characters which would be > - * generated for the given input, excluding the trailing null, > - * as per ISO C99. If the return is greater than or equal to > - * @size, the resulting string is truncated. > - * > - * See the vsprintf() documentation for format string extensions over C99. > - */ > -int snprintf(char *buf, size_t size, const char *fmt, ...) > - __attribute__ ((format (__printf__, 3, 4))); > - > /** > * Format a string and place it in a buffer > * Please move the whole thing, comment and attributes over not just the basic prototype, thanks. -- Tom
signature.asc
Description: PGP signature
