Re: [PATCH RFC v2 08/23] rockchip: RK3588: Read the reset cause from clock reset unit for RK3588 SoC

[Dragan Simic]

Hello Anand,

On 2024-05-31 16:18, Anand Moon wrote:

From: Anand Moon <an...@edgeble.ai>

Read the reset cause from clock reset unit for RK3588 SoC.

Cc: Jagan Teki <ja...@edgeble.ai>
Signed-off-by: Anand Moon <an...@edgeble.ai>
Signed-off-by: Anand Moon <linux.am...@gmail.com>
---
 arch/arm/include/asm/arch-rockchip/cru.h | 2 ++
 arch/arm/mach-rockchip/cpu-info.c        | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/arch/arm/include/asm/arch-rockchip/cru.h
b/arch/arm/include/asm/arch-rockchip/cru.h
index a1499e9652..19bd2b405b 100644
--- a/arch/arm/include/asm/arch-rockchip/cru.h
+++ b/arch/arm/include/asm/arch-rockchip/cru.h
@@ -19,6 +19,8 @@
 # include <asm/arch-rockchip/cru_rk3399.h>
 #elif defined(CONFIG_ROCKCHIP_RK3568)
 #include <asm/arch-rockchip/cru_rk3568.h>

Although not related to this patch directly, single space character
should be added between "#" and "include", for consistency.

+#elif defined(CONFIG_ROCKCHIP_RK3588)
+#include <asm/arch-rockchip/cru_rk3588.h>

The same comment as above, bit this time related to this patch.

 #endif

 /* CRU_GLB_RST_ST */
diff --git a/arch/arm/mach-rockchip/cpu-info.c
b/arch/arm/mach-rockchip/cpu-info.c
index e12f84a1d2..113a03acdf 100644
--- a/arch/arm/mach-rockchip/cpu-info.c
+++ b/arch/arm/mach-rockchip/cpu-info.c
@@ -20,6 +20,8 @@ char *get_reset_cause(void)
        struct rockchip_cru *cru = rockchip_get_cru();
 #elif IS_ENABLED(CONFIG_ROCKCHIP_RK3568)
        struct rk3568_cru *cru = rockchip_get_cru();
+#elif IS_ENABLED(CONFIG_ROCKCHIP_RK3588)
+       struct rk3588_cru *cru = rockchip_get_cru();
 #endif
        char *cause = NULL;