Re: [PATCH RFC v2 14/23] rockchip: RK3308: Read the reset cause from clock reset unit for RK3308 SoC

[Dragan Simic]

Hello Anand,

On 2024-05-31 16:18, Anand Moon wrote:

From: Anand Moon <an...@edgeble.ai>

Read the reset cause from clock reset unit for RK3308 SoC.

Cc: Jagan Teki <ja...@edgeble.ai>
Signed-off-by: Anand Moon <an...@edgeble.ai>
Signed-off-by: Anand Moon <linux.am...@gmail.com>
---
 arch/arm/include/asm/arch-rockchip/cru.h | 2 ++
 arch/arm/mach-rockchip/cpu-info.c        | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/arch/arm/include/asm/arch-rockchip/cru.h
b/arch/arm/include/asm/arch-rockchip/cru.h
index 7a69a839e6..6fe73ad0cc 100644
--- a/arch/arm/include/asm/arch-rockchip/cru.h
+++ b/arch/arm/include/asm/arch-rockchip/cru.h
@@ -23,6 +23,8 @@
 #include <asm/arch-rockchip/cru_rk3588.h>

Although not related to this patch directly, a single space character
should be added between "#" and "include", for consistency.

 #elif defined(CONFIG_ROCKCHIP_PX30)
 #include <asm/arch-rockchip/cru_px30.h>

The same comment as above.

+#elif defined(CONFIG_ROCKCHIP_RK3308)
+#include <asm/arch-rockchip/cru_rk3308.h>

The same comment as above, bit this time related to this patch.

 #endif

 /* CRU_GLB_RST_ST */
diff --git a/arch/arm/mach-rockchip/cpu-info.c
b/arch/arm/mach-rockchip/cpu-info.c
index 383aa3d2ee..dbc126c862 100644
--- a/arch/arm/mach-rockchip/cpu-info.c
+++ b/arch/arm/mach-rockchip/cpu-info.c
@@ -26,6 +26,8 @@ char *get_reset_cause(void)
        struct px30_cru *cru = rockchip_get_cru();
 #elif IS_ENABLED(CONFIG_ROCKCHIP_RK3288)
        struct rockchip_cru *cru = rockchip_get_cru();
+#elif IS_ENABLED(CONFIG_ROCKCHIP_RK3308)
+       struct rk3308_cru *cru = rockchip_get_cru();
 #endif
        char *cause = NULL;