Hi Marek,
On 2024-06-13 3:12 pm, Marek Vasut wrote:
On 6/13/24 9:49 AM, Claudius Heine wrote:
Hi,
[...]
Also, while I checked OE-Core, other third party/community maintained
layer could be impacted. I assume this is the case of
meta-amarula-engicam[1] and meta-allwinner-hx[2] for example.
I would suggest sending a mail to the different build systems mailing
lists, I assume https://lists.openembedded.org/g/openembedded-devel
and https://lists.yoctoproject.org/g/yocto for the OE-Core/YP side?
Either to ask for their opinion or notify them (and specifically
third party layers) it's going away or both.
Not sure if I want to go through them all. Looking into all these 3rd
party, downstream repos and informing everyone seems to be even more
effort than maintaining the git protocol.
And if someone uses their repo, they will notice it quickly and can
easily fix it.
I very much agree, that ^ is probably the best way to go.
If some legacy repository breaks, fix the repository, hopefully there
aren't too many of those to fix. Github deprecated git protocol a few
years back and users managed too, except the fallout here is much
smaller as it affects only one recipe (or a few).
I suspect the following patch to oe-core (or local.conf equivalent)
might also entirely mitigate the issue by providing https fallback
automatically, without the need to modify the legacy layer/recipe ?
If so, maybe this could be added to OE LTS releases at least ?
"
diff --git a/meta/classes-global/mirrors.bbclass
b/meta/classes-global/mirrors.bbclass
index 862648eec5..50a14c5881 100644
--- a/meta/classes-global/mirrors.bbclass
+++ b/meta/classes-global/mirrors.bbclass
@@ -77,6 +77,7 @@ https?://downloads.yoctoproject.org/mirror/sources/
https://mirrors.kernel.org/y
MIRRORS += "\
git://salsa.debian.org/.*
git://salsa.debian.org/PATH;protocol=https \
+git://git.denx.de/.* git://git.denx.de/PATH;protocol=https \
Well the path will change a bit as well:
git://git.denx.de/u-boot.git -> https://source.denx.de/u-boot/u-boot.git
git://git.denx.de/u-boot-efi.git ->
https://source.denx.de/u-boot/custodians/u-boot-efi.git
git://git.denx.de/xenomai.git -> https://source.denx.de/xenomai/xenomai.git
git://git.denx.de/mxssb.git -> https://source.denx.de/denx/mxssb.git
If we want to make it perfect, it will be more difficult than that.
git://git.gnome.org/.* git://gitlab.gnome.org/GNOME/PATH;protocol=https \
git://git.infradead.org/.*
git://git.infraroot.at/PATH;protocol=https \
git://.*/.* git://HOST/PATH;protocol=https \
"
Anyway, I fixed it yesterday, and it doesn't make much sense to stop
it now. So I will leave it in place until it breaks again, then I just
remove it.
Do you know how long it was actually broken ? (i.e. how long nobody
noticed and complained about it?)
So since 3rd of June, so about 5-8 days or so until someone noticed.
I mean I could make it fail 10% of the time, and issue a deprecation
notice, and then raise that percentage each month a bit higher... Maybe
some kind of scaling, the fewer people use it in a certain time, the
oftener it fails... :D
regards,
Claudius
--
DENX Software Engineering GmbHt, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: c...@denx.de
