On Thu, Jun 27, 2024 at 01:36:09PM -0600, Tom Rini wrote: > On Thu, Jun 27, 2024 at 02:31:13PM +0300, Mikhail Kshevetskiy wrote: > > > From: Michael Polyntsov <michael.polynt...@iopsys.eu> > > > > If hardware (or driver) doesn't support leds blinking, it's > > now possible to use software implementation of blinking instead. > > This relies on cyclic functions. > > > > Signed-off-by: Michael Polyntsov <michael.polynt...@iopsys.eu> > > Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevets...@iopsys.eu> > > --- > > drivers/led/Kconfig | 9 ++ > > drivers/led/led-uclass.c | 190 ++++++++++++++++++++++++++++++++++++++- > > 2 files changed, 195 insertions(+), 4 deletions(-) > > As one of those "well, hunh" kind of moment, I'm cc'ing Christian > Marangi who also just posted patches foor this kind of functionality. >
Eh... Well this implementation is better. I had the idea of adding support on the uclass level but I preferred to limit it only to GPIO. Think this would match how it's done in upstream linux kernel so I think mine should be ignored and this taken (for sw blink). Should not change a thing for the series since all the bits were using generic LED functions. -- Ansuel