On 7/25/24 20:27, Tom Rini wrote: > On Thu, Jul 25, 2024 at 02:57:27PM +0200, Jerome Forissier wrote: > >> Add a function to start a given etwork device, and update eth_init() > > Typo, "network". Fixed in v6. >> to use it. >> >> Signed-off-by: Jerome Forissier <jerome.foriss...@linaro.org> > > And this is where most of the tiny and acceptable growth comes from in > the legacy network case. > > Reviewed-by: Tom Rini <tr...@konsulko.com> > > But, does the lwIP side end up calling this too then, and so the need to > split this out and not have it be static? Yes, eth_start_udev() is called by new_netif() in net/lwip/net-lwip.c. Thanks, -- Jerome
- [PATCH v5 00/20] Introduce the lwIP network stack Jerome Forissier
- [PATCH v5 01/20] flash: prefix error codes with FL_ Jerome Forissier
- Re: [PATCH v5 01/20] flash: prefix error codes w... Tom Rini
- Re: [PATCH v5 01/20] flash: prefix error cod... Jerome Forissier
- [PATCH v5 04/20] net: fec_mxc_init(): do not ignore ... Jerome Forissier
- [PATCH v5 06/20] net: eth-uclass: add function eth_s... Jerome Forissier
- Re: [PATCH v5 06/20] net: eth-uclass: add functi... Tom Rini
- Re: [PATCH v5 06/20] net: eth-uclass: add fu... Jerome Forissier
- [PATCH v5 07/20] net-lwip: build lwIP Jerome Forissier
- [PATCH v5 05/20] net: split include/net.h into net{,... Jerome Forissier
- [PATCH v5 09/20] net-lwip: add TFTP support and tftp... Jerome Forissier
- [PATCH v5 11/20] net-lwip: add dns command Jerome Forissier
- [PATCH v5 12/20] net: split cmd/net.c into cmd/net.c... Jerome Forissier
- Re: [PATCH v5 12/20] net: split cmd/net.c into c... Ilias Apalodimas
- [PATCH v5 13/20] net-lwip: add wget command Jerome Forissier
- [PATCH v5 14/20] net-lwip: lwIP wget supports user d... Jerome Forissier
- [PATCH v5 15/20] cmd: bdinfo: enable -e when CONFIG_... Jerome Forissier
- [PATCH v5 10/20] net-lwip: add ping command Jerome Forissier