On 7/25/24 20:18, Tom Rini wrote: > On Thu, Jul 25, 2024 at 02:57:22PM +0200, Jerome Forissier wrote: > >> Prefix the flash status codes (ERR_*) with FL_ in order to avoid clashes >> with third-party libraries. Case in point: including the lwIP library >> header file <lwip/err.h> which defines err_enum_t as an enum with values >> being ERR_*. >> >> Signed-off-by: Jerome Forissier <jerome.foriss...@linaro.org> >> Reviewed-by: Tom Rini <tr...@konsulko.com> >> Reviewed-by: Ilias Apalodimas <ilias.apalodi...@linaro.org> > > This is incomplete as for example 10m50 fails to build due to > drivers/mtd/altera_qspi.c. It might be worth doing a world build with > just this commit applied to check for other problems as well, in v6. Fixed in v6. I have now grepped -w all the ERR_ codes and it was the only one I missed. Thanks, -- Jerome
- [PATCH v5 00/20] Introduce the lwIP network stack Jerome Forissier
- [PATCH v5 01/20] flash: prefix error codes with FL_ Jerome Forissier
- Re: [PATCH v5 01/20] flash: prefix error codes w... Tom Rini
- Re: [PATCH v5 01/20] flash: prefix error cod... Jerome Forissier
- [PATCH v5 04/20] net: fec_mxc_init(): do not ignore ... Jerome Forissier
- [PATCH v5 06/20] net: eth-uclass: add function eth_s... Jerome Forissier
- Re: [PATCH v5 06/20] net: eth-uclass: add functi... Tom Rini
- Re: [PATCH v5 06/20] net: eth-uclass: add fu... Jerome Forissier
- [PATCH v5 07/20] net-lwip: build lwIP Jerome Forissier
- [PATCH v5 05/20] net: split include/net.h into net{,... Jerome Forissier
- [PATCH v5 09/20] net-lwip: add TFTP support and tftp... Jerome Forissier
- [PATCH v5 11/20] net-lwip: add dns command Jerome Forissier
- [PATCH v5 12/20] net: split cmd/net.c into cmd/net.c... Jerome Forissier
- Re: [PATCH v5 12/20] net: split cmd/net.c into c... Ilias Apalodimas