Hi Udit, On 19:44-20241222, Kumar, Udit wrote: > > On 12/17/2024 4:37 PM, Manorit Chawdhry wrote: > > Based off j784s4 configs with delta changes for J742S2 > > > > [ Add AVS support for J742S2 ] > > Signed-off-by: Keerthy <[email protected]> > > Signed-off-by: Manorit Chawdhry <[email protected]> > > --- [..] > > diff --git a/configs/j742s2_evm_r5_defconfig > > b/configs/j742s2_evm_r5_defconfig > > new file mode 100644 > > index > > 0000000000000000000000000000000000000000..2be6318df76632dd2cc5cbeebcb6ce674cd80338 > > --- /dev/null > > +++ b/configs/j742s2_evm_r5_defconfig > > @@ -0,0 +1,9 @@ > > +#include <configs/j784s4_evm_r5_defconfig> > > + > > +CONFIG_ARM=y > > +CONFIG_ARCH_K3=y > > +CONFIG_SOC_K3_J784S4=y > > Isn't above enabled by j784s4_evm_r5_defconfig
These are actually required by buildman to be functional so even if we have them we need to re-define these after including as well iiuc. > > > > +CONFIG_TARGET_J742S2_R5_EVM=y > > +CONFIG_DEFAULT_DEVICE_TREE="k3-j742s2-r5-evm" > > +CONFIG_SPL_OF_LIST="k3-j742s2-r5-evm" > > Also, AVS is enable with > https://lore.kernel.org/all/[email protected]/ > series > > So please update k3_avs.c if needed as part of initial series. I think this should not be required, we have the DT parsing and the configs are propagated from j784s4 configs only. The vtm node is also kept in common file (k3-j784s4-r5.dtsi) so that should also be here so I think we have the necessary stuff for keeping AVS functional.. Regards, Manorit
