Hi Udit, On 19:37-20241222, Kumar, Udit wrote: > > On 12/17/2024 4:37 PM, Manorit Chawdhry wrote: > > J742S2 has the same part number as J784S4 but JTAG_DEVICE_ID has a > > PKG bit that tells about J742S2. > > > > Add support for reading JTAG_DEVICE_ID and set family as J742S2 based > > on that. > > > > Link: https://www.ti.com/lit/pdf/spruje3 (TRM) > > Signed-off-by: Manorit Chawdhry <[email protected]> > > --- [..] > > diff --git a/drivers/soc/soc_ti_k3.c b/drivers/soc/soc_ti_k3.c > > index > > a3acca4d394273aad53efd3eee200ecdda50c31b..f8e64395ae3f18513837a88cf91d340fc11bb346 > > 100644 > > --- a/drivers/soc/soc_ti_k3.c > > +++ b/drivers/soc/soc_ti_k3.c > > @@ -18,9 +18,14 @@ struct soc_ti_k3_plat { > > static const char *get_family_string(u32 idreg) > > { > > const char *family; > > + u32 jtag_dev_id; > > + u32 pkg; > > u32 soc; > > + jtag_dev_id = readl(CTRLMMR_WKUP_JTAG_DEVICE_ID); > > Please check, if this register is available for all k3 devices. > > if not then please move this logic under J784S4 SOC. > > Second compilation will fail for few k3 devices , which does not define > CTRLMMR_WKUP_JTAG_DEVICE_ID
Ah yeah, thanks for catching it! Will fix it in the next revision. Regards, Manorit
