> -----Original Message----- > From: u-b...@lakedaemon.net [mailto:u-b...@lakedaemon.net] > Sent: Monday, June 06, 2011 6:04 PM > To: u-boot@lists.denx.de > Cc: Prafulla Wadaskar; Jason Cooper > Subject: [PATCH 0/3 v2] RFC: Dreamplug support > > From: Jason Cooper <u-b...@lakedaemon.net> > > It compiles clean, and I've loaded it via JTAG and used it to dump the > existing bootloader out of the SPI flash. I have _not_ used it to burn > itself to the flash yet. I'm looking for comments before I try that. ;- > ) > > Some concerns: > > 1.) does the 'make all' support need to be last? I've used > rebase to edit patches and commits, but I've never reshuffled. > Each patch compiles clean. FIXED in v2. > > 2.) The SPI flash chip is a Macronix MX25L1606, however it has the > identical chip idcode to the MX25L1605. How is that properly > handled? The 06 does have some new features [1]. > > 3.) I added the board number [2], etc to asm/mach-types.h even > though it says to not to. ;-) Is there a proper way to do it? > If it's copied from the Linux kernel, it hasn't been updated in > a while...
No, the proper way is- you should add board first to arm-linux, then the updated mach-types.h will be updated by arm maintainer on u-boot, then you can add your board support. > > [1] > http://www.macronix.com/QuickPlace/hq/PageLibrary4825740B00298A3B.nsf/h_ > Index/5F41CDDCB837422C48257639003E5EC3/$File/AN055- > Migrate_to_MX25L1606E_and_MX25L8006E-1.2.pdf > [2] http://www.arm.linux.org.uk/developer/machines/list.php?id=3550 > > > Changes from v1 to v2: > > - resorted series to move 'make all' support last. > > > Jason Cooper (3): > dreamplug: Initial support. > dreamplug: switch from NAND flash to SPI flash. > dreamplug: include in 'make all' > > MAKEALL | 1 + > arch/arm/include/asm/mach-types.h | 13 +++ No patch for this file, follow process explained above. > board/Marvell/dreamplug/Makefile | 51 +++++++++++ > board/Marvell/dreamplug/dreamplug.c | 153 > ++++++++++++++++++++++++++++++++ > board/Marvell/dreamplug/dreamplug.h | 39 ++++++++ > board/Marvell/dreamplug/kwbimage.cfg | 160 > ++++++++++++++++++++++++++++++++++ > boards.cfg | 1 + > include/configs/dreamplug.h | 111 +++++++++++++++++++++++ You should update MAINTAINERS file too. Regards.. Prafulla . . _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot