Prafulla,

Thanks for the input!  I assume the SPI flash implementation looked ok?

On Mon, Jun 06, 2011 at 11:47:15PM -0700, Prafulla Wadaskar wrote:
> 
> > -----Original Message-----
> > From: u-b...@lakedaemon.net [mailto:u-b...@lakedaemon.net]
> > Sent: Monday, June 06, 2011 6:04 PM
> > To: u-boot@lists.denx.de
> > Cc: Prafulla Wadaskar; Jason Cooper
> > Subject: [PATCH 0/3 v2] RFC: Dreamplug support
> > 
> >     3.) I added the board number [2], etc to asm/mach-types.h even
> >         though it says to not to. ;-)  Is there a proper way to do it?
> >         If it's copied from the Linux kernel, it hasn't been updated in
> >         a while...
> 
> No, the proper way is- you should add board first to arm-linux, then
> the updated mach-types.h will be updated by arm maintainer on u-boot,
> then you can add your board support.
> 

Ok, I'll starting working on the Linux side as well.

> > 
> > [2] http://www.arm.linux.org.uk/developer/machines/list.php?id=3550
> > 
> > 
> > Changes from v1 to v2:
> > 
> >     - resorted series to move 'make all' support last.
> > 
> > 
> > Jason Cooper (3):
> >   dreamplug: Initial support.
> >   dreamplug: switch from NAND flash to SPI flash.
> >   dreamplug: include in 'make all'
> > 
> >  MAKEALL                              |    1 +
> >  arch/arm/include/asm/mach-types.h    |   13 +++
> 
> No patch for this file, follow process explained above.
> 

So, in the interim, I'll resubmit using the guruplug board id, then
submit separate patch after the Linux support is accepted.

> >  board/Marvell/dreamplug/Makefile     |   51 +++++++++++
> >  board/Marvell/dreamplug/dreamplug.c  |  153
> > ++++++++++++++++++++++++++++++++
> >  board/Marvell/dreamplug/dreamplug.h  |   39 ++++++++
> >  board/Marvell/dreamplug/kwbimage.cfg |  160
> > ++++++++++++++++++++++++++++++++++
> >  boards.cfg                           |    1 +
> >  include/configs/dreamplug.h          |  111 +++++++++++++++++++++++
> 
> You should update MAINTAINERS file too.
> 

Ok, I'll add Dreamplug under Siddarth Gore.

> Regards..
> Prafulla . .
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to