----- "Prafulla Wadaskar" <prafu...@marvell.com> wrote: > > -----Original Message----- > > From: Ajay Bhargav [mailto:ajay.bhar...@einfochips.com] > > Sent: Wednesday, August 17, 2011 2:18 PM > > To: Prafulla Wadaskar > > Cc: u-boot@lists.denx.de > > Subject: Re: [PATCH v6 1/2] gpio: Add GPIO driver framework for > Marvell > > SoCs > > > > > > ----- "Prafulla Wadaskar" <prafu...@marvell.com> wrote: > > > > > Hi Ajay > > > I am sorry if I missed this in my earlier reviews. > > > > > > Why you wish to keep mvgpio.h in /include folder? > > > I think it should be in drivers/gpio/. > > > > > > Regards.. > > > Prafulla . . > > > > > > > Hi Prafulla, > > > > gpio.h includes this file, as GPIO_LEVEL_SET/CLR are defined > > in mvgpio.h which may be needed by other files accessing gpios. > > In my case I am using gpio for PHY reset. I was thinking not to > > keep any magic number 1/0 for set/clr gpio pin. > > Hi Ajay > > In any case this gpio driver will be used by other drivers or board > specific code to configure/set/clear particular gpio. And that is > possible by just including asm/gpio.h and using standard gpio calls. > > So in any case keeping mvgpio.h in include folder does not make any > sense to me. > > If needed, layered architecture suggest to include asm/gpio.h in your > code, which will include asm/arch/gpio.h to get your architecture > specific gpio definitions, I don't think this will be needed if you > use standard API calls. > > Regards.. > Prafulla . . > got it... I kind of misundestood.. I will move it to driver/gpio will that be ok?
Regards, Ajay Bhargav _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot