On Wednesday, August 24, 2011 05:42:06 PM Mike Frysinger wrote:
> On Wednesday, August 24, 2011 09:07:18 Ajay Bhargav wrote:
> > + darmdfec->p_rxdesc = (struct rx_desc *) memalign(PKTALIGN,
> > + ARMDFEC_RXQ_DESC_ALIGNED_SIZE * RINGSZ + 1);
>
> memalign() returns a void*, so you shouldnt need to cast its return value
> (you do this a couple of times)
>
> > + /* Read mac from env if available */
> > + eth_getenv_enetaddr("ethaddr", dev->enetaddr);
>
> you shouldnt need to do this. the higher layers will take care of this for
> you when you set write_hwaddr
>
> also, it seems like some of my previous feedback wasnt addressed ?
I have exactly the same feeling :-(
Ajay, please go through the feedback, if you don't understand something, just
ask instead of hoping we won't notice ... we will, we see everything ;-)
Cheers
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
