On Thursday, August 25, 2011 07:24:22 AM Ajay Bhargav wrote: > ----- "Marek Vasut" <marek.va...@gmail.com> wrote: > > On Wednesday, August 24, 2011 05:42:06 PM Mike Frysinger wrote: > > > On Wednesday, August 24, 2011 09:07:18 Ajay Bhargav wrote: > > > > + darmdfec->p_rxdesc = (struct rx_desc *) > > > > memalign(PKTALIGN, > > > > > > + ARMDFEC_RXQ_DESC_ALIGNED_SIZE * RINGSZ + > > > > 1); > > > > > memalign() returns a void*, so you shouldnt need to cast its return > > > > value > > > > > (you do this a couple of times) > > > > > > > + /* Read mac from env if available */ > > > > + eth_getenv_enetaddr("ethaddr", dev->enetaddr); > > > > > > you shouldnt need to do this. the higher layers will take care of > > > > this for > > > > > you when you set write_hwaddr > > > > > > also, it seems like some of my previous feedback wasnt addressed ? > > > > I have exactly the same feeling :-( > > > > Ajay, please go through the feedback, if you don't understand > > something, just > > ask instead of hoping we won't notice ... we will, we see everything > > ;-) > > > > Cheers > > I did go through your feedbacks.. My apologies if I missed. Marek, Its good > for me that you guys are monitoring :) it will surely help me to write a > better code :)
It's good thing you don't whine and run away ... some people do. Btw. your code is quite good, it just need the finishing touch :) Cheers > > Thanks, > Ajay Bhargav _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot