On Monday, September 19, 2011 10:43:14 AM Stefano Babic wrote: > On 09/18/2011 04:19 AM, Jana Rapava wrote: > > From: Marek Vasut <marek.va...@gmail.com> > > > > This commit adds USB support for EfikaMX and EfikaSB. > > > > Signed-off-by: Marek Vasut <marek.va...@gmail.com> > > Signed-off-by: Jana Rapava <ferma...@gmail.com> > > ---
[...] > > + > > + > > +#ifdef CONFIG_MACH_EFIKASB > > Have I missed something ? In U-Boot I see only MACH_TYPE_MX51_EFIKAMX. > And I cannot find any patch on the ML for the EfikaSB board. > If you add support for a EfikaMX variant, you should add this variant in > your patchset, else this stuff is only dead code and must be removed. I'd prefer this to stay where it is. It's a code for another version of efika which I plan to add very soon (after I clean it up): http://git.denx.de/?p=u-boot/u-boot- pxa.git;a=commit;h=3d5f5c53819eeddf2088237e592c49bf97a5764c http://git.denx.de/?p=u-boot/u-boot- pxa.git;a=commit;h=d1298fdce8ff4ee3d6a485c935e231b9d0d6189e I might actually submit those on wednesday or so. [...] > > +u32 ulpi_read(u32 reg, struct usb_ehci *ehci) > > A ulpi_read() as ulpi_write() is not strictly related to the Efika board. We're missing generic ulpi infrastructure and adding it is way beyond scope of this patch. Cheers _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot