Hi Stefano, 2011/9/19 Stefano Babic <sba...@denx.de>: > you change several files, some of them in the general USB support. You > must then split your patch into a patchset, and each patch must address > a single issue. Really with your patch you do not only add USB support > to the EfikaMX board, but you want to add support for MX5 Soc and maybe > fix some issues. And if you change some general USB files, you should
I agree that this patch must be split up into a patchset. > add in CC the USB maintainer (Remy, I have already added him in my answer). Thanks. >> +#include "../../drivers/usb/host/ehci.h" >> +#include "../../drivers/usb/host/ehci-core.h" > > This seems to me pretty nasty - but it is not the only example in u-boot > including files from drivers/. Can we imagine to move these files into > the include directory ? I think it is a good idea to move these headers to include/usb. Patches are welcome. Kind regards, Remy _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
