> -----Original Message----- > From: Wolfgang Denk [mailto:w...@denx.de] > Sent: Monday, October 24, 2011 3:37 AM > To: Zang Roy-R61911 > Cc: u-boot@lists.denx.de; Fleming Andy-AFLEMING; Kumar Gala > Subject: Re: [U-Boot] [PATCH] powerpc/fm: remove the TBIPA setting on platform > code > > Dear Roy Zang, > > In message <1319178713-12472-1-git-send-email-tie-fei.z...@freescale.com> you > wrote: > > TBIPA has been set in dtsec_init_phy () funciton in drivers/net/fm/eth.c > > > > So remove the duplicate code on platform Ethernet code. > > > > Signed-off-by: Roy Zang <tie-fei.z...@freescale.com> > > Cc: Andy Fleming <aflem...@freescale.com> > > Cc: Kumar Gala <ga...@kernel.crashing.org> > > Please change the Subject: so everybody understands what you are > doing. "powerpc/fm" is not exactly clear to everybody, and neither is > TBIPA. > > Nor is clear which processors / processor families / boards are > affected. Per my understand, subject is a summary of the patch. poweper/fm and TBIPA should almost be OK for the subject. I can point out that the code is about the network code in subject. for example, Subject: powerpc/fm: remove the TBIPA setting on platform network related code
Then I add more in the patch description to explain fm, TBIPA, processors, processor families/boards affected. Thanks. Roy _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
