Hi Mike, On Tue, Oct 25, 2011 at 2:39 PM, Mike Frysinger <vap...@gentoo.org> wrote: > On Tue, Oct 25, 2011 at 17:35, Simon Glass wrote: >> On Sat, Oct 22, 2011 at 10:29 PM, Mike Frysinger wrote: >>> On Sat, Oct 22, 2011 at 00:51, Simon Glass wrote: >>>> + sprintf(str, "%x", (uintptr_t)addr); >>> >>> i wonder if we should use %p and drop the cast >> >> Is %p supposed to print a 0x before it or not? I saw some discussion >> about this. I vote for %p no, and %#p yes. > > %p does not currently output a leading 0x. it should (imo), and i'll > prob send a patch to fix that. > > but %x doesn't output a leading 0x either :). > -mike >
OK, well to be consistent with glibc we should probably add 0x as you say. isn't it intended that env variables without a leading 0x in the value be interpreted as hex still? Iwc do I really want the 0x? Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot