On 10/27/2011 12:23 AM, Heiko Schocher wrote: >>> In drivers/mtd/nand/davinci_nand.c CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST >>> is used, and there are 4bit specific functions, so this define is >>> also valid, just we need in drivers/mtd/nand/nand_spl_simple.c a more >>> common name, right? >> >> Right. Ideally, though, that would either be CONFIG_SYS_DAVINCI_... or >> #if defined(CONFIG_SYS_NAND_HW_ECC_OOBFIRST) && \ >> defined(CONFIG_SYS_NAND_HW_ECC_4BIT) > > Hmm.. I thought you meant, this is not davinci nor 4bit specific? > Or do you mean to rename the CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST > define in drivers/mtd/nand/davinci_nand.c?
I just mean that "4bit" and "oobfirst" are independent things, so I'd rather not have something that combines the two as part of the configuration of the general NAND interface in the absence of a requirement to enumerate all possibilities. OTOH, the structure of driver's private config can be whatever makes the most sense for that driver, but should be named in a way that it's obviously driver-specific. -Scott _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
