On Thursday 10 November 2011 09:21:53 Simon Guinot wrote: > On Thu, Nov 10, 2011 at 01:01:59PM +0100, Wolfgang Denk wrote: > > Simon Guinot wrote: > > > > > Let's remove this broken code. > > > > > > > > This is exactly part of this patch ([PATCH] mvgbe: remove setting of > > > > ethaddr within the driver). This part, while ACK'ed by Mike, was > > > > NAK'ed by Prafulla. > > > > > > As some boards are relying on this broken code, maybe you should > > > provide an alternative ? I could be wrong, but it seems to me that > > > just removing the code is not enough. > > > > Which exact boards are these? And how exactly are these relying on the > > broken code? > > I can't list this boards exactly. For sure, I can say that the > LaCie boards (netspace_v2 and cie) are concerned. > > For this boards a random MAC address is used and the computation is > performed by the driver mvgbe. If this code is simply removed, the > network initialization for this boards will break.
it will be broken until you set "ethaddr" in the env right ? i think that's currently the expected behavior ... -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot