Hi Wolfgang, Am Donnerstag 10 November 2011, 12:44:26 schrieb Wolfgang Denk: > Dear Prafulla, > > In message <48935aa530a6457b76b9915a1fe7faf9.squir...@ssl.serverraum.org> Michael Walle wrote: > > >> So was there any conclusion, now? Never touch mvgbe.c anymore? > > > > > > Let's remove this broken code. > > > > This is exactly part of this patch ([PATCH] mvgbe: remove setting of > > ethaddr within the driver). This part, while ACK'ed by Mike, was NAK'ed > > by Prafulla. > > Could you please revise your assessment? I would really appreciate if > we could clean this up. Regarding Prafulla's NAK?
Let me sum up this thread once again: - consens is found that the driver should be cleaned up (removing the randomization code) - at least the keymile boards are ok with that. but there may be plenty of other boards which rely on this (broken?) behaviour. - besides the fact that a driver must not touch the environment, the mvgbe driver also fails to do this correctly for boards which has only the second port enabled. - Prafulla NAKed because only removing the code will leave some boards in a non-working state. i'm willing make a patch to move the randomization functionality to some generic place, but only if it is not NAKed by you beforehand. i dont have any time to waste ;) -- Michael _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot