On 12/05/2011 02:40 PM, Simon Glass wrote: > Hi Stephen, > > On Mon, Dec 5, 2011 at 1:27 PM, Stephen Warren <swar...@nvidia.com> wrote: >> On 12/02/2011 07:11 PM, Simon Glass wrote: >> ... >>> +int fdtdec_get_is_enabled(const void *blob, int node) >>> { >>> const char *cell; >>> >>> cell = fdt_getprop(blob, node, "status", NULL); >>> if (cell) >>> - return 0 == strcmp(cell, "ok"); >>> - return default_val; >>> + return 0 == strcmp(cell, "okay"); >>> + return 1; >>> } >> >> The kernel accepts both okay (standard) and ok (non-standard). I assume >> the latter is required for some in-use-but-technically-incorrect .dts >> files. I imagine U-Boot should act like the kernel here. > > Given that we are just starting out with fdt, do you think it would be > better to not bloat the code in this way? I don't mind either way - > just asking :-)
My point is that there are probably .dts files using "ok" instead of "okay" or the kernel wouldn't support "ok". People will probably want to use those with U-Boot without changing anything else. So, U-Boot should interpret the FDT in the same way as the kernel. -- nvpublic _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot