Dear Wolfgang Denk, On 5 January 2012 17:02, Wolfgang Denk <w...@denx.de> wrote: > Dear Chander Kashyap, > > In message > <canuqghhy8_6m1riva6rawry0pvrx5nnykxd_p+u340a0d4j...@mail.gmail.com> you > wrote: >> >> > No need to reuse the code, if SoCs are different. >> > If need, please separate the functions. >> >> Yes, though SoC's are different, the functionality in clock.c is >> similar. The only difference is the clock name in the clock structure >> for Exynos4 and Exynos5 but the functionality is exactly same in >> clock.c. To accommodate this change in clock name #ifdef is used. > > If this is the only difference, then I suggest just to rename the > field in thesta structure. Although it makes sense to follow the names > in the documentation, it is sometimes better tochose a more suitable > name - a comment in the header file should be sufficient to explain > the rename (and to provide an anchor in case something greps for the > name as used in the docs). > > Maybe we can avoid both #ifdef's and code duplication this way? Thanks for the suggestion. > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > What was sliced bread the greatest thing since?
-- with warm regards, Chander Kashyap _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
