On 18/04/2012 10:54, Timo Ketola wrote: > Signed-off-by: Timo Ketola <t...@exertus.fi> > --- > arch/arm/include/asm/arch-mx25/imx-regs.h | 29 +++++++++ > drivers/video/Makefile | 1 + > drivers/video/mx2fb.c | 92 > +++++++++++++++++++++++++++++ > include/lcd.h | 21 ++++++- > include/mx2fb.h | 39 ++++++++++++ > 5 files changed, 181 insertions(+), 1 deletions(-) > create mode 100644 drivers/video/mx2fb.c > create mode 100644 include/mx2fb.h
Hi Timo, I forward your patch to Anatolji. He is the video maintainer. > > diff --git a/arch/arm/include/asm/arch-mx25/imx-regs.h > b/arch/arm/include/asm/arch-mx25/imx-regs.h > index 7f9449b..af5b42e 100644 > --- a/arch/arm/include/asm/arch-mx25/imx-regs.h > +++ b/arch/arm/include/asm/arch-mx25/imx-regs.h > @@ -167,6 +167,35 @@ struct aips_regs { > u32 mpr_8_15; > }; > > +struct lcdc_regs { > + u32 lssar; > + u32 lsr; > + u32 lvpwr; > + u32 lcpr; > + u32 lcwhb; > + u32 lccmr; > + u32 lpcr; > + u32 lhcr; > + u32 lvcr; > + u32 lpor; > + u32 lscr; > + u32 lpccr; > + u32 ldcr; > + u32 lrmcr; > + u32 licr; > + u32 lier; > + u32 lisr; > + u32 pad0[3]; > + u32 lgwsar; > + u32 lgwsr; > + u32 lgwvpwr; > + u32 lgwpor; > + u32 lgwpr; > + u32 pad1[0x200 - 25]; > + u32 bglut[0x100]; > + u32 gwlut[0x100]; > +}; > + > #endif > > /* AIPS 1 */ > diff --git a/drivers/video/Makefile b/drivers/video/Makefile > index 6252f6a..e047471 100644 > --- a/drivers/video/Makefile > +++ b/drivers/video/Makefile > @@ -36,6 +36,7 @@ COBJS-$(CONFIG_VIDEO_CT69000) += ct69000.o videomodes.o > COBJS-$(CONFIG_VIDEO_DA8XX) += da8xx-fb.o videomodes.o > COBJS-$(CONFIG_VIDEO_MB862xx) += mb862xx.o videomodes.o > COBJS-$(CONFIG_VIDEO_MB86R0xGDC) += mb86r0xgdc.o videomodes.o > +COBJS-$(CONFIG_VIDEO_MX2) += mx2fb.o > COBJS-$(CONFIG_VIDEO_MX3) += mx3fb.o videomodes.o > COBJS-$(CONFIG_VIDEO_MX5) += mxc_ipuv3_fb.o ipu_common.o ipu_disp.o > COBJS-$(CONFIG_VIDEO_OMAP3) += omap3_dss.o videomodes.o > diff --git a/drivers/video/mx2fb.c b/drivers/video/mx2fb.c > new file mode 100644 > index 0000000..9ee4a3e IMHO it is better if you use the video API instead of the old LCD interface, that means using CONFIG_VIDEO. You have then to implement a video_hw_init() function for your initialisation. I think there are advantages doing that, and recently some drivers moved to this API, for example the driver for i.MX3 (mx3fb.c). > > diff --git a/include/mx2fb.h b/include/mx2fb.h > new file mode 100644 > index 0000000..1f16a61 > --- /dev/null > +++ b/include/mx2fb.h > @@ -0,0 +1,39 @@ > +/* > + * Copyright 2004-2009 Freescale Semiconductor, Inc. All Rights Reserved. > + */ > + > +/* > + * The code contained herein is licensed under the GNU General Public > + * License. You may obtain a copy of the GNU General Public License > + * Version 2 or later at the following locations: > + * > + * http://www.opensource.org/licenses/gpl-license.html > + * http://www.gnu.org/copyleft/gpl.html > + */ The header is not correct, I think - it does not set explicitely under which license version is published this code, only where it is possible to get a GPLv2 or later. Please substitute this header with a full explained license header, as you can see generally in u-boot files. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot