Marc, > -----Original Message----- > From: Marc Dietrich [mailto:marvi...@gmx.de] > Sent: Sunday, September 16, 2012 9:17 AM > To: Tom Warren > Cc: Stephen Warren; u-boot@lists.denx.de > Subject: Re: [PATCH 2/2] tegra: enable lp0 on paz00 > > Tom, > > On Monday 10 September 2012 12:32:00 Tom Warren wrote: > > > -----Original Message----- > > > From: Stephen Warren [mailto:swar...@wwwdotorg.org] > > > Sent: Monday, September 10, 2012 12:08 PM > > > To: Marc Dietrich > > > Cc: u-boot@lists.denx.de; Tom Warren > > > Subject: Re: [PATCH 2/2] tegra: enable lp0 on paz00 > > > > > > On 09/10/2012 12:51 PM, Marc Dietrich wrote: > > > > This enables LP0 to support suspend / resume on PAZ00. > > > > > > Ooh. Did you test this out with the AC100 kernel, and have it work? > > > That'd be pretty cool... > > > > > > > diff --git a/board/compal/paz00/Makefile > > > > b/board/compal/paz00/Makefile > > > > > > > > -COBJS := $(BOARD).o > > > > -COBJS += ../../nvidia/common/board.o > > > > +COBJS-y := $(BOARD).o > > > > +COBJS-y += ../../nvidia/common/board.o > > > > +COBJS-$(CONFIG_TEGRA_CLOCK_SCALING) += ../../nvidia/common/emc.o > > > > > > Hmmm. That's odd. I'd expect that to be part of the core Tegra code, > > > rather than something boards have to pull in manually. > > I checked this again. The Makefile in nvidia/common is never executed on non > nvidia boards (it is included from the topdir Makefile > ($vendor/common/Makefile). > > Therefore the explicit "COBJS += ../../nvidia/common/board.o" in the paz00 > Makefile is needed. So either we have to add ../../nvidia/common/foo.o to > all non nvidia boards or we "source" the whole Makefile somehow else. > > Marc Feel free to submit a patch that does one or the other (patches all non-nvidia Makefiles or sources the whole Makefile). I think I'd prefer the first approach, though it's ugly having ../.. 'reach arounds' in the Makefiles.
Once you have a fix, we can discuss its merits and move forward. Thanks, Tom > > > Stephen's right - this is already done in > > ../cpu/tegra20-common/Makefile when CONFIG_TEGRA_CLOCK_SCALING is > > defined. So no need to change the PAZ00 Makefile. > > > > diff --git a/include/configs/paz00.h b/include/configs/paz00.h > > > > > > > > +/* LP0 suspend / resume */ > > > > +#define CONFIG_TEGRA20_LP0 > > > > > > That's been renamed CONFIG_TEGRA_LP0 in u-boot-tegra/next. > > > > As part of the pre-work for Tegra30 changes, I've changed generic > > Tegra defines, labels, etc. to be more non-specific, unless it does > > really refer to a Tegra20 feature, file, etc. As Stephen says, see > > u-boot-tegra/next's top commit. > > > > Tom -- nvpublic _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot