Hi Bruno, Cc Guodong's new mail address On 08:52 Tue 25 Aug , Bruno Banelli wrote: > board_fit_config_name_match() derives the device tree name from the TLV > product name held in the board EEPROM, and only recognises boards whose > product name starts with "k1-x_". > > Boards fitted with the higher-binned M1 part report an "m1-x_" prefix > instead. On those, fdt_name is left empty and the function silently > falls back to "k1-musepi-pro", so an M1 board selects the wrong device > tree with no error or warning. > > A Milk-V Jupiter fitted with an M1 reads, from the 24c04 at i2c2 0x50: > > 00: 54 6c 76 49 6e 66 6f 00 01 00 1a 21 12 6d 31 2d TlvInfo....!.m1- > 10: 78 5f 6d 69 6c 6b 76 2d 6a 75 70 69 74 65 72 fe x_milkv-jupiter. > > i.e. TLV code 0x21 (product name), length 0x12, "m1-x_milkv-jupiter". > > The device trees are named for the K1 in both cases, so accept either > prefix and keep deriving a "k1-" name. > > Signed-off-by: Bruno Banelli <[email protected]>
Looks good Reviewd-by: Yixun Lan <[email protected]> -- Yixun Lan (dlan)
