On 8/26/26 13:16, Ilias Apalodimas wrote:
Hi Heinrich,


On Thu, 20 Aug 2026 at 16:08, Heinrich Schuchardt <[email protected] <mailto:[email protected]>> wrote:

    Use EFI_PRINT() instead of debug() to correctly indent the message.

    Signed-off-by: Heinrich Schuchardt
    <[email protected]
    <mailto:[email protected]>>
    ---
      lib/efi_loader/efi_rng.c | 2 +-
      1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/lib/efi_loader/efi_rng.c b/lib/efi_loader/efi_rng.c
    index 7810b4e47ea..9c5a60ea963 100644
    --- a/lib/efi_loader/efi_rng.c
    +++ b/lib/efi_loader/efi_rng.c
    @@ -31,7 +31,7 @@ __weak efi_status_t platform_get_rng_device(struct
    udevice **dev)

             ret = uclass_get_device(UCLASS_RNG, 0, &devp);
             if (ret) {
    -               debug("Unable to get rng device\n");
    +               EFI_PRINT("Unable to get rng device\n");


All the users of that function print a similar message on failure. IMHO just remove the print completely

In response to patch 2/2 you suggested to eliminate all caller messages instead. But I missed efi_rng_register().

I will respin the series accordingly.

Best regards

Heinrich


Cheers
/Ilias

                     return EFI_DEVICE_ERROR;
             }

-- 2.53.0


Reply via email to